From: Li Zefan <lizf@cn.fujitsu.com>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: linux-ext4@vger.kernel.org, "Theodore Ts'o" <tytso@mit.edu>
Subject: [PATCH] ext4: remove redundant code in ext4_fill_super()
Date: Fri, 30 May 2008 13:14:25 +0800 [thread overview]
Message-ID: <483F8D31.7090505@cn.fujitsu.com> (raw)
The previous sb_min_blocksize() has already set the block size.
This piece of code was introduced in commit:
afc7cbca5bfd556c3e12d3acefbee5ab0cbd4670
(ext4: Support large blocksize up to PAGESIZE)
And it should be a mistake.
Signed-off-by: Li Zefan <lizf@cn.fujitsu.com>
---
fs/ext4/super.c | 5 -----
1 files changed, 0 insertions(+), 5 deletions(-)
diff --git a/fs/ext4/super.c b/fs/ext4/super.c
index 09d9359..5d07aa9 100644
--- a/fs/ext4/super.c
+++ b/fs/ext4/super.c
@@ -1843,11 +1843,6 @@ static int ext4_fill_super (struct super_block *sb, void *data, int silent)
goto out_fail;
}
- if (!sb_set_blocksize(sb, blocksize)) {
- printk(KERN_ERR "EXT4-fs: bad blocksize %d.\n", blocksize);
- goto out_fail;
- }
next reply other threads:[~2008-05-30 5:15 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-05-30 5:14 Li Zefan [this message]
2008-05-30 20:57 ` [PATCH] ext4: remove redundant code in ext4_fill_super() Mingming Cao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=483F8D31.7090505@cn.fujitsu.com \
--to=lizf@cn.fujitsu.com \
--cc=akpm@linux-foundation.org \
--cc=linux-ext4@vger.kernel.org \
--cc=tytso@mit.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.