From: Antti Palosaari <crope@iki.fi>
Cc: linux-dvb@linuxtv.org
Subject: Re: [linux-dvb] Oops in tda10023
Date: Fri, 30 May 2008 18:25:23 +0300 [thread overview]
Message-ID: <48401C63.1010601@iki.fi> (raw)
In-Reply-To: <484014AC.3090603@gmail.com>
e9hack wrote:
> Antti Palosaari schrieb:
>>> I think the oops occurs, because tda10023_writereg() fails in tda10023_attach(). If
>>> tda10023_writereg fails, an error message is printed. In this case,
>>> state->frontend.dvb->num is accessed, but it isn't initialized yet.
>> hmm, I see the problem now. Originally state was initialized before
>> tda10023_writereg() was called but after I did some changes this is not
>> done anymore. And when writereg() fails in attach some reason it oops.
>
> It wasn't introduced with your modifications. The frontend.dvb part is initialized after
> the attach call. tda10023_writereg() must check, if state->frontend.dvb is initialized or
> not.
yeah, you are correct. I looked through all frontend drivers and only
TDA10021 and TDA10023 was using dvb->num in writereg. Anyhow, TDA10021
is not affected because it does not write in attach.
Antti
--
http://palosaari.fi/
_______________________________________________
linux-dvb mailing list
linux-dvb@linuxtv.org
http://www.linuxtv.org/cgi-bin/mailman/listinfo/linux-dvb
next prev parent reply other threads:[~2008-05-30 15:26 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-05-29 16:50 [linux-dvb] Oops in tda10023 Sigmund Augdal
2008-05-29 17:52 ` Antti Palosaari
2008-05-30 9:15 ` Sigmund Augdal
2008-05-30 12:49 ` Antti Palosaari
2008-05-30 13:59 ` e9hack
2008-05-30 14:35 ` Antti Palosaari
2008-05-30 14:52 ` e9hack
2008-05-30 15:25 ` Antti Palosaari [this message]
2008-05-30 20:30 ` Antti Palosaari
2008-05-30 21:12 ` e9hack
2008-05-30 22:24 ` Oliver Endriss
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=48401C63.1010601@iki.fi \
--to=crope@iki.fi \
--cc=linux-dvb@linuxtv.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.