From mboxrd@z Thu Jan 1 00:00:00 1970 From: Scott Wood Subject: Re: [PATCH 2/2] talitos: Freescale integrated security engine (SEC) driver Date: Fri, 30 May 2008 15:36:50 -0500 Message-ID: <48406562.4010306@freescale.com> References: <20080529141250.0946b02c.kim.phillips@freescale.com> <20080530180904.GA18945@2ka.mipt.ru> <20080530143614.1e675228.kim.phillips@freescale.com> <4840585D.8050805@freescale.com> <20080530151638.087970ab.kim.phillips@freescale.com> <4840615F.4070103@freescale.com> <20080530153505.21eb1ec4.kim.phillips@freescale.com> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Cc: Evgeniy Polyakov , linuxppc-dev@ozlabs.org, mr.scada@gmail.com, linux-crypto@vger.kernel.org, herbert@gondor.apana.org.au To: Kim Phillips Return-path: Received: from az33egw01.freescale.net ([192.88.158.102]:51028 "EHLO az33egw01.freescale.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752879AbYE3UtT (ORCPT ); Fri, 30 May 2008 16:49:19 -0400 In-Reply-To: <20080530153505.21eb1ec4.kim.phillips@freescale.com> Sender: linux-crypto-owner@vger.kernel.org List-ID: Kim Phillips wrote: > On Fri, 30 May 2008 15:19:43 -0500 > Scott Wood wrote: > >> Kim Phillips wrote: >>> On Fri, 30 May 2008 14:41:17 -0500 >>> Scott Wood wrote: >>> >>>> Kim Phillips wrote: >>>>> On Fri, 30 May 2008 22:09:04 +0400 >>>>> Evgeniy Polyakov wrote: >>>>>> Don't you want to protect against simultaneous access to register space >>>>>> from different CPUs? Or it is single processor board only? >>>>> Doesn't linux mask the IRQ line for the interrupt currently being >>>>> serviced, and on all processors? >>>> Yes. Could there be interference from non-interrupt driver code on >>>> another cpu (or interrupted code), though? >>> not that I can see - the fetch fifo register writes are protected with >>> per-channel spinlocks. >> But you don't take the spinlocks from the interrupt handler. > > why can't fetch fifo registers be written the same time the ISR is > being accessed? I don't know -- you brought them up. My question was whether there's anything that the ISR touches that is also touched by non-ISR code. -Scott