From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with archive (Exim 4.43) id 1K2CRa-0004oo-40 for mharc-grub-devel@gnu.org; Fri, 30 May 2008 17:47:26 -0400 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1K2CRY-0004og-Tu for grub-devel@gnu.org; Fri, 30 May 2008 17:47:24 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1K2CRV-0004nq-Mi for grub-devel@gnu.org; Fri, 30 May 2008 17:47:23 -0400 Received: from [199.232.76.173] (port=46285 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1K2CRV-0004nn-Fd for grub-devel@gnu.org; Fri, 30 May 2008 17:47:21 -0400 Received: from mailout11.t-online.de ([194.25.134.85]:49657) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1K2CRV-000332-9L for grub-devel@gnu.org; Fri, 30 May 2008 17:47:21 -0400 Received: from fwd33.aul.t-online.de by mailout11.sul.t-online.de with smtp id 1K2CRT-0003o8-00; Fri, 30 May 2008 23:47:19 +0200 Received: from [10.3.2.2] (Zk5Ix+ZUgh6qjypHQrqIexiBG6p4Kn6yVkEshUCllrYyPRxpcSWusiotJcL8n9oQrH@[217.235.237.197]) by fwd33.aul.t-online.de with esmtp id 1K2CRQ-0j8UjI0; Fri, 30 May 2008 23:47:16 +0200 Message-ID: <484075E6.9030709@t-online.de> Date: Fri, 30 May 2008 23:47:18 +0200 From: Christian Franke User-Agent: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8.1.11) Gecko/20071128 SeaMonkey/1.1.7 MIME-Version: 1.0 To: The development of GRUB 2 References: <20080530212032.GA1672@thorin> In-Reply-To: <20080530212032.GA1672@thorin> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-ID: Zk5Ix+ZUgh6qjypHQrqIexiBG6p4Kn6yVkEshUCllrYyPRxpcSWusiotJcL8n9oQrH X-TOI-MSGID: 6e5afeb6-0845-464e-96ad-36fc187ef8af X-detected-kernel: by monty-python.gnu.org: Linux 2.6 (newer, 3) Subject: Re: backwards compatibility in grub.cfg X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: The development of GRUB 2 List-Id: The development of GRUB 2 List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 30 May 2008 21:47:25 -0000 Robert Millan wrote: > diff -x configure -x config.h.in -x CVS -x '*~' -x '*.mk' -urp ../grub2/util/update-grub_lib.in ./util/update-grub_lib.in > --- ../grub2/util/update-grub_lib.in 2008-05-30 22:55:35.000000000 +0200 > +++ ./util/update-grub_lib.in 2008-05-30 23:16:53.000000000 +0200 > @@ -116,10 +116,9 @@ prepare_grub_to_access_device () > > # If there's a filesystem UUID that GRUB is capable of identifiing, use it; > # otherwise set root as per value in device.map. > + echo "set root=`${grub_probe} --device ${device} --target=drive`" > if fs_uuid="`grub-probe --device ${device} --target=fs_uuid 2> /dev/null`" ; then > Outside of the scope of the patch, but shouldn't '${grub_probe}' be used instead of 'grub-probe' in the rest of the script? Same issue is in update-grub.in: grub_probe is set but never used, so update-grub fails if /usr/sbin is not in PATH. -- Christian Franke