From: Jeff Garzik <jeff@garzik.org>
To: Rusty Russell <rusty@rustcorp.com.au>
Cc: netdev@vger.kernel.org, virtualization@lists.linux-foundation.org
Subject: Re: [PATCH 1/3] virtio: fix virtio_net xmit of freed skb bug
Date: Fri, 30 May 2008 22:12:40 -0400 [thread overview]
Message-ID: <4840B418.5060607@garzik.org> (raw)
In-Reply-To: <200805261742.43215.rusty@rustcorp.com.au>
Rusty Russell wrote:
> If we fail to transmit a packet, we assume the queue is full and put
> the skb into last_xmit_skb. However, if more space frees up before we
> xmit it, we loop, and the result can be transmitting the same skb twice.
>
> Fix is simple: set skb to NULL if we've used it in some way, and check
> before sending.
>
> Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
> ---
> drivers/net/virtio_net.c | 14 +++++++++-----
> 1 file changed, 9 insertions(+), 5 deletions(-)
applied 1-2 (#3 was already applied)
next prev parent reply other threads:[~2008-05-31 2:12 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-05-26 7:42 [PATCH 1/3] virtio: fix virtio_net xmit of freed skb bug Rusty Russell
2008-05-26 7:48 ` [PATCH 2/3] virtio: fix delayed xmit of packet and freeing of old packets Rusty Russell
2008-05-26 7:48 ` Rusty Russell
2008-05-26 7:53 ` [PATCH 3/3] virtio: Use __skb_queue_purge() Rusty Russell
2008-05-26 8:11 ` Wang Chen
2008-05-26 8:11 ` Wang Chen
2008-05-26 7:53 ` Rusty Russell
2008-05-27 11:01 ` [PATCH 2/3] virtio: fix delayed xmit of packet and freeing of old packets Mark McLoughlin
2008-05-27 11:01 ` Mark McLoughlin
2008-05-28 4:59 ` Rusty Russell
2008-05-28 4:59 ` Rusty Russell
2008-05-27 11:06 ` [PATCH 1/3] virtio: fix virtio_net xmit of freed skb bug Mark McLoughlin
2008-05-29 6:34 ` Rusty Russell
2008-05-29 6:34 ` Rusty Russell
2008-06-13 14:14 ` Mark McLoughlin
2008-06-13 14:14 ` Mark McLoughlin
2008-06-13 19:57 ` Jeff Garzik
2008-06-13 19:57 ` Jeff Garzik
2008-06-14 7:39 ` Rusty Russell
2008-06-14 7:39 ` Rusty Russell
2008-05-27 11:06 ` Mark McLoughlin
2008-05-31 2:12 ` Jeff Garzik
2008-05-31 2:12 ` Jeff Garzik [this message]
-- strict thread matches above, loose matches on Subject: below --
2008-05-26 7:42 Rusty Russell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4840B418.5060607@garzik.org \
--to=jeff@garzik.org \
--cc=netdev@vger.kernel.org \
--cc=rusty@rustcorp.com.au \
--cc=virtualization@lists.linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.