From: Jeff Garzik <jgarzik@pobox.com>
To: Ben Hutchings <bhutchings@solarflare.com>
Cc: netdev@vger.kernel.org, linux-net-drivers@solarflare.com
Subject: Re: [PATCH] sfc: Report XAUI link down at default log level
Date: Fri, 30 May 2008 22:13:02 -0400 [thread overview]
Message-ID: <4840B42E.4030707@pobox.com> (raw)
In-Reply-To: <20080530211835.GE1743@solarflare.com>
Ben Hutchings wrote:
> This is normal when the external link is down so don't report it as an error.
>
> Signed-off-by: Ben Hutchings <bhutchings@solarflare.com>
> ---
> drivers/net/sfc/falcon_xmac.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/net/sfc/falcon_xmac.c b/drivers/net/sfc/falcon_xmac.c
> index 264e1ee..37d3cae 100644
> --- a/drivers/net/sfc/falcon_xmac.c
> +++ b/drivers/net/sfc/falcon_xmac.c
> @@ -513,7 +513,7 @@ static int falcon_check_xaui_link_up(struct efx_nic *efx)
> tries--;
> }
>
> - EFX_ERR(efx, "Failed to bring XAUI link back up in %d tries!\n",
> + EFX_LOG(efx, "Failed to bring XAUI link back up in %d tries!\n",
> max_tries);
applied
prev parent reply other threads:[~2008-05-31 2:13 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-05-30 21:18 [PATCH] sfc: Report XAUI link down at default log level Ben Hutchings
2008-05-31 2:13 ` Jeff Garzik [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4840B42E.4030707@pobox.com \
--to=jgarzik@pobox.com \
--cc=bhutchings@solarflare.com \
--cc=linux-net-drivers@solarflare.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.