From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jeff Garzik Subject: Re: [PATCH -next] cxgb3: fix build error when INET=n Date: Fri, 30 May 2008 22:19:49 -0400 Message-ID: <4840B5C5.2010206@pobox.com> References: <20080530102919.ecd1fb27.randy.dunlap@oracle.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20080530102919.ecd1fb27.randy.dunlap@oracle.com> Sender: netdev-owner@vger.kernel.org To: Randy Dunlap Cc: netdev , divy@chelsio.com, linux-next@vger.kernel.org, akpm List-Id: linux-next.vger.kernel.org Randy Dunlap wrote: > From: Randy Dunlap > > cxgb3 uses lro_* functions and selects INET_LRO, but this doesn't help unless > INET is already enabled, so make the driver depend on INET also. > > sge.c:(.text+0x9f09a): undefined reference to `lro_flush_all' > sge.c:(.text+0x9f62f): undefined reference to `lro_receive_skb' > sge.c:(.text+0x9f8a3): undefined reference to `lro_receive_frags' > sge.c:(.text+0x9fbe0): undefined reference to `lro_vlan_hwaccel_receive_skb' > sge.c:(.text+0x9ffcd): undefined reference to `lro_vlan_hwaccel_receive_frags' > > Signed-off-by: Randy Dunlap > --- > drivers/net/Kconfig | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > --- linux-next-20080530.orig/drivers/net/Kconfig > +++ linux-next-20080530/drivers/net/Kconfig > @@ -2407,7 +2407,7 @@ config CHELSIO_T1_NAPI > > config CHELSIO_T3 > tristate "Chelsio Communications T3 10Gb Ethernet support" > - depends on PCI > + depends on PCI && INET > select FW_LOADER > select INET_LRO > help > -- applied