From: Shinya Kuribayashi <skuribay@ruby.dti.ne.jp>
To: u-boot@lists.denx.de
Subject: [U-Boot-Users] [PATCH 3/3][MIPS] lib_mips/time.c: Fix improper use of CFG_HZ and timer routines
Date: Sat, 31 May 2008 15:12:30 +0900 [thread overview]
Message-ID: <4840EC4E.4070108@ruby.dti.ne.jp> (raw)
In-Reply-To: <20080525151838.40B982402D@gemini.denx.de>
Wolfgang Denk wrote:
> In message <48396D8C.8050402@ruby.dti.ne.jp> you wrote:
>> My udelay is already global-variable-free. And as for cycles_per_jiffy
>> and expirelo, we could make it work like this:
> ...
>> -static unsigned int expirelo;
>> +static unsigned long cycles_per_jiffy = (CONFIG_MIPS_TIMER_FREQ + CFG_HZ / 2) / CFG_HZ;
>
> If it's a constant anyway - then why do we need a variable for it?
Of course, we don't. That was for easy review, will fix.
>> But I have no clue about timestamp.
>
> Maybe there is a register that is (1) common to all or at least most
> of the supported processors we could use for that? If not, then we
I'm afraid there's not such register left.
> probably have to use the initial data structure for this.
Looked around board_init_r, and it seems there is no {set,get}_timer
user there. I'm going to leave timestamp as it is at this moment.
Shinya
next prev parent reply other threads:[~2008-05-31 6:12 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-05-20 16:24 [U-Boot-Users] [PATCH] [resend] mips: Support to set CFG_HZ to 1000, consistent with other architectures Jason McMullan
2008-05-21 3:53 ` Shinya Kuribayashi
2008-05-21 15:32 ` Scott Wood
2008-05-24 12:58 ` [U-Boot-Users] [PATCH 1/3][MIPS] lib_mips/time.c: Replace CP0 access functions with existing macros Shinya Kuribayashi
2008-05-24 12:59 ` [U-Boot-Users] [PATCH 2/3][MIPS] lib_mips/time.c: Fix udelay Shinya Kuribayashi
2008-05-24 13:02 ` [U-Boot-Users] [PATCH 3/3][MIPS] lib_mips/time.c: Fix improper use of CFG_HZ and timer routines Shinya Kuribayashi
2008-05-24 19:59 ` Wolfgang Denk
2008-05-25 2:04 ` Shinya Kuribayashi
2008-05-25 8:15 ` Wolfgang Denk
2008-05-25 13:45 ` Shinya Kuribayashi
2008-05-25 15:18 ` Wolfgang Denk
2008-05-31 6:12 ` Shinya Kuribayashi [this message]
2008-05-31 6:17 ` Shinya Kuribayashi
2008-05-31 14:40 ` [U-Boot-Users] [PATCH 3/3 v2][MIPS] lib_mips/time.c: Fix CP0 count register usage " Shinya Kuribayashi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4840EC4E.4070108@ruby.dti.ne.jp \
--to=skuribay@ruby.dti.ne.jp \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.