From: Jeremy Fitzhardinge <jeremy@goop.org>
To: Jeff Garzik <jgarzik@pobox.com>
Cc: Jens Axboe <jens.axboe@oracle.com>, LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 2 of 5] xn/blkfront: Add the CDROM_GET_CAPABILITY ioctl to blkfront
Date: Sat, 31 May 2008 08:08:01 +0100 [thread overview]
Message-ID: <4840F951.1090908@goop.org> (raw)
In-Reply-To: <4840B077.70705@pobox.com>
Jeff Garzik wrote:
> Jeremy Fitzhardinge wrote:
>> + case CDROM_GET_CAPABILITY: {
>> + struct gendisk *gd = info->gd;
>> + if (gd->flags & GENHD_FL_CD)
>> + return 0;
>> + return -EINVAL;
>> + }
>
>
> Surely you can come up with a better implementation than this? It's
> just a bitmask returned to userspace...
Unfortunately the Xen block driver interface doesn't seem to pass
through any capabilities of the underlying CDROM device, so there's not
much to return. I suspect this is primarily a hack to make installers a
bit happier installing off a Xen VBD rather than because real programs
will use this in earnest.
J
next prev parent reply other threads:[~2008-05-31 7:08 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-05-31 0:01 [PATCH 0 of 5] xen device driver updates [resend] Jeremy Fitzhardinge
2008-05-31 0:01 ` [PATCH 1 of 5] xen/blkfront: Make sure we don't use bounce buffers, we don't need them Jeremy Fitzhardinge
2008-05-31 1:55 ` Jeff Garzik
2008-05-31 0:01 ` [PATCH 2 of 5] xn/blkfront: Add the CDROM_GET_CAPABILITY ioctl to blkfront Jeremy Fitzhardinge
2008-05-31 1:57 ` Jeff Garzik
2008-05-31 7:08 ` Jeremy Fitzhardinge [this message]
2008-05-31 0:01 ` [PATCH 3 of 5] xen/blkfront: Make sure that the device is fully ready before allowing release Jeremy Fitzhardinge
2008-05-31 0:01 ` [PATCH 4 of 5] xen/blkfront: add __exit to module_exit() handlers Jeremy Fitzhardinge
2008-05-31 1:57 ` Jeff Garzik
2008-05-31 0:01 ` [PATCH 5 of 5] xen: Avoid allocations causing swap activity on the resume path Jeremy Fitzhardinge
2008-05-31 1:58 ` Jeff Garzik
2008-05-31 9:50 ` Jeremy Fitzhardinge
2008-05-31 9:59 ` Andrew Morton
2008-05-31 10:10 ` Jeremy Fitzhardinge
2008-05-31 23:47 ` Andrew Morton
2008-06-01 0:38 ` Jeremy Fitzhardinge
2008-05-31 1:54 ` [PATCH 0 of 5] xen device driver updates [resend] Jeff Garzik
2008-05-31 6:31 ` Jeremy Fitzhardinge
-- strict thread matches above, loose matches on Subject: below --
2008-05-30 23:50 [PATCH 0 of 5] xen device driver updates Jeremy Fitzhardinge
2008-05-30 23:50 ` [PATCH 2 of 5] xn/blkfront: Add the CDROM_GET_CAPABILITY ioctl to blkfront Jeremy Fitzhardinge
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4840F951.1090908@goop.org \
--to=jeremy@goop.org \
--cc=jens.axboe@oracle.com \
--cc=jgarzik@pobox.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.