From: Patrick McHardy <kaber@trash.net>
To: Jan Engelhardt <jengelh@medozas.de>
Cc: Thomas Jarosch <thomas.jarosch@intra2net.com>,
Krzysztof Oledzki <ole@ans.pl>,
netfilter-devel@vger.kernel.org
Subject: Re: iptables version defines
Date: Sun, 01 Jun 2008 23:13:58 +0200 [thread overview]
Message-ID: <48431116.8000607@trash.net> (raw)
In-Reply-To: <alpine.LNX.1.10.0805301246450.11875@fbirervta.pbzchgretzou.qr>
Jan Engelhardt wrote:
> On Friday 2008-05-30 12:06, Thomas Jarosch wrote:
>> Hi Krzysztof,
>>
>> On Friday, 30. May 2008 11:56:28 you wrote:
>>>> #ifdef _XTABLES_H
>>>> init(struct xt_entry_target *t)
>>>> #else
>>>> init(struct ipt_entry_target *t, unsigned int *nfcache)
>>>> #endif
>
> Woah this is ridiculously ugly. (Remember, such constructs were
> just eliminated from the kernel in the past years.)
I don't care about uglyness as long as it stays in external
code. So if someone sends me a patch to add this version
define, I'll add it.
next prev parent reply other threads:[~2008-06-01 21:14 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-05-30 8:16 iptables version defines Thomas Jarosch
2008-05-30 9:41 ` Krzysztof Oledzki
2008-05-30 9:56 ` Krzysztof Oledzki
2008-05-30 10:06 ` Thomas Jarosch
2008-05-30 10:53 ` Jan Engelhardt
2008-06-01 21:13 ` Patrick McHardy [this message]
[not found] ` <200806021545.23690.thomas.jarosch@intra2net.com>
2008-06-02 13:50 ` [patch] " Patrick McHardy
2008-05-30 10:05 ` Krzysztof Oledzki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=48431116.8000607@trash.net \
--to=kaber@trash.net \
--cc=jengelh@medozas.de \
--cc=netfilter-devel@vger.kernel.org \
--cc=ole@ans.pl \
--cc=thomas.jarosch@intra2net.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.