From: Patrick McHardy <kaber@trash.net>
To: Jarek Poplawski <jarkao2@gmail.com>
Cc: David Miller <davem@davemloft.net>,
Eric Sesterhenn <snakebyte@gmx.de>,
netdev@vger.kernel.org
Subject: Re: [PATCH][NETFILTER]: fix inconsistent lock state in nf_ct_frag6_gather()
Date: Mon, 02 Jun 2008 12:43:42 +0200 [thread overview]
Message-ID: <4843CEDE.8030409@trash.net> (raw)
In-Reply-To: <20080530215314.GA2485@ami.dom.local>
Jarek Poplawski wrote:
> According to this and another similar lockdep report inet_fragment
> locks are taken from nf_ct_frag6_gather() with softirqs enabled, but
> these locks are mainly used in softirq context, so disabling BHs is
> necessary.
Yes, this can happen on the local output path,
> David & Patrick,
>
> It looks like this patch could be applied.
Looks mostly fine, but don't we also have to disable BHs for
the inet_frag_find() call in nf_ct_frag6_gather()?
next prev parent reply other threads:[~2008-06-02 10:43 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-05-29 12:02 Inconsistend lock state in inet_frag_find Eric Sesterhenn
2008-05-30 10:53 ` Jarek Poplawski
2008-05-30 13:18 ` Eric Sesterhenn
2008-05-30 17:10 ` Jarek Poplawski
2008-05-30 21:13 ` Eric Sesterhenn
2008-05-30 21:53 ` [PATCH][NETFILTER]: fix inconsistent lock state in nf_ct_frag6_gather() Jarek Poplawski
2008-06-02 10:43 ` Patrick McHardy [this message]
2008-06-02 12:45 ` Jarek Poplawski
2008-06-02 13:24 ` Patrick McHardy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4843CEDE.8030409@trash.net \
--to=kaber@trash.net \
--cc=davem@davemloft.net \
--cc=jarkao2@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=snakebyte@gmx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.