All of lore.kernel.org
 help / color / mirror / Atom feed
From: Wolfgang Grandegger <wg@grandegger.com>
To: u-boot@lists.denx.de
Subject: [U-Boot-Users] [PATCH] MPC8360ERDK: adapt NAND interface for the re-written	FSL NAND UPM driver
Date: Mon, 02 Jun 2008 14:59:08 +0200	[thread overview]
Message-ID: <4843EE9C.2060206@grandegger.com> (raw)
In-Reply-To: <20080602114534.GB25335@polina.dev.rtsoft.ru>

Anton Vorontsov wrote:
> On Mon, Jun 02, 2008 at 12:14:51PM +0200, Wolfgang Grandegger wrote:
>> MPC8360ERDK: adapt NAND interface for the re-written FSL NAND UPM driver
>>
>> This patch is based on the following patch sent a few minutes ago:
>> "[PATCH] NAND FSL UPM: driver re-write using the hwcontrol callback"
>> It is untested, of course. Anton, could you please give it a try.
>>
>> Signed-off-by: Wolfgang Grandegger <wg@grandegger.com>
> 
> Acked-by: Anton Vorontsov <avorontsov@ru.mvista.com>
> 
> [...]
>> @@ -68,5 +89,9 @@ int board_nand_init(struct nand_chip *na
>>  	fun.upm.mxmr = &im->lbus.mamr;
>>  	fun.upm.mdr = &im->lbus.mdr;
>>  	fun.upm.mar = &im->lbus.mar;
>> +
>> +	if (!upm_setup_done)
> 
> Not sure if this is really needed for this board though, nobody will
> call this function more than once...

Right, also because io_addr is hard coded. I will remove it.

Wolfgang.

      reply	other threads:[~2008-06-02 12:59 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-06-02 10:14 [U-Boot-Users] [PATCH] MPC8360ERDK: adapt NAND interface for the re-written FSL NAND UPM driver Wolfgang Grandegger
2008-06-02 11:45 ` Anton Vorontsov
2008-06-02 12:59   ` Wolfgang Grandegger [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4843EE9C.2060206@grandegger.com \
    --to=wg@grandegger.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.