All of lore.kernel.org
 help / color / mirror / Atom feed
From: Mark Lord <liml@rtr.ca>
To: Jeff Garzik <jeff@garzik.org>
Cc: Alan Cox <alan@lxorguk.ukuu.org.uk>, Pavel Machek <pavel@ucw.cz>,
	Kristen Carlson Accardi <kristen.c.accardi@intel.com>,
	Theodore Tso <tytso@mit.edu>,
	linux-ide@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] ata: ahci: power off unused ports
Date: Mon, 02 Jun 2008 09:03:04 -0400	[thread overview]
Message-ID: <4843EF88.2040606@rtr.ca> (raw)
In-Reply-To: <4843A4A7.3020809@garzik.org>

Jeff Garzik wrote:
> Alan Cox wrote:
>>> If you are talking about SATA -- incorrect.
>>>
>>> The patch deals with policy, and the user MUST have the ability to 
>>> control this stuff.  Otherwise you create a situation where the user 
>>> might be denied hotplug use in valid cases, or similar negative 
>>> situations.
>>
>> The policy isn't however complicated. Tejun added the stuff for forcing
>> cable type and mode on setup and has therefore written all the per device
>> setup code we might need. Alternatively a single
>>
>>     foo=1/0
>>
>> option has been fine for acpi and will do fine for this. Total additional
>> cost - 1 line.
> 
> The key requirement is per-port control.  Ideally via hdparm or another 
> userspace tool, but kernel command line (module options) or sysfs would 
> be just fine too.  And agreed, the minimal you need is simply 1/0 for 
> the port's policy.
..

Btw.. hdparm-8.7 (unreleased) can grok /sys now, so that interface is
as good as any from a userspace viewpoint now.

For the power-off of unused ports, the current patch still sounds
extremely vendor-specific (Intel).

Does it actually work (demonstrate, please) on any other hardware ?

I would still like to see a far more generic solution, with periodic polling
and the like, which would permit use on *any* machines (eg. data centers)
without loss of hotplug capability on those ports.

But that's probably just wishful thinking at this point.

Cheers

  parent reply	other threads:[~2008-06-02 13:03 UTC|newest]

Thread overview: 41+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-05-08 23:10 [PATCH] ata: ahci: power off unused ports Kristen Carlson Accardi
2008-05-08 23:37 ` Matthew Garrett
2008-05-08 23:35   ` Kristen Carlson Accardi
2008-05-09  0:14     ` Matthew Garrett
2008-05-09  0:28       ` Kristen Carlson Accardi
2008-05-09 15:58   ` Lennart Sorensen
2008-05-09 16:06     ` Matthew Garrett
2008-05-09 16:14       ` Lennart Sorensen
2008-05-09 17:14         ` Kristen Carlson Accardi
2008-05-09 17:14           ` Kristen Carlson Accardi
2008-05-09 15:06 ` Mark Lord
2008-05-09 15:28   ` Port control interface (was Re: [PATCH] ata: ahci: power off unused ports) Jeff Garzik
2008-05-27  3:08 ` [PATCH] ata: ahci: power off unused ports Theodore Tso
2008-05-27 21:32   ` Kristen Carlson Accardi
2008-05-27 22:59     ` Theodore Tso
2008-05-27 23:32       ` Kristen Carlson Accardi
2008-05-31  8:00         ` Pavel Machek
2008-06-01 19:16           ` Jeff Garzik
2008-06-02  7:04             ` Alan Cox
2008-06-02  7:43               ` Jeff Garzik
2008-06-02  8:22                 ` Alan Cox
2008-06-02  9:48                   ` Jeff Garzik
2008-06-02 13:54                     ` Alan Cox
2008-06-02 16:55                     ` Kristen Carlson Accardi
2008-06-02 13:03                 ` Mark Lord [this message]
2008-06-02 16:07                   ` Jeff Garzik
2008-06-02 17:00                     ` Kristen Carlson Accardi
2008-06-02 17:45                       ` Jeff Garzik
2008-06-02 17:47                         ` Kristen Carlson Accardi
2008-06-02 18:15                           ` Jeff Garzik
2008-06-02 18:16                             ` Kristen Carlson Accardi
2008-06-02 18:30                               ` Ric Wheeler
2008-06-02 18:40                                 ` Jeff Garzik
2008-06-02 18:49                                   ` Ric Wheeler
2008-06-02 18:52                                     ` Jeff Garzik
2008-06-02 20:00                                   ` Matthew Garrett
2008-06-02 18:38                               ` Jeff Garzik
2008-06-03 16:49                                 ` Kristen Carlson Accardi
2008-06-02 17:07                     ` Greg Freemyer
2008-06-02 16:57                   ` Kristen Carlson Accardi
2008-06-02 17:44                     ` Jeff Garzik

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4843EF88.2040606@rtr.ca \
    --to=liml@rtr.ca \
    --cc=alan@lxorguk.ukuu.org.uk \
    --cc=jeff@garzik.org \
    --cc=kristen.c.accardi@intel.com \
    --cc=linux-ide@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=pavel@ucw.cz \
    --cc=tytso@mit.edu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.