Re: [PATCH][ASoC V2] Make Freescale MPC8610 drivers more dynamic

[Timur Tabi <timur@freescale.com>]

Mark Brown wrote:

> This change means that if someone builds another board with the same CPU
> on it then they'll have to add all the objects for the core CPU support
> to the Makefile entry for their board.

They'll need to update Kconfig and the Makefile anyway, so I decided to cut out
the "middle man" -- the SOC.

>  There should at least be a
> separate Kconfig thing, even if it's not user visible.  I've committed a
> patch backing this bit out for now.

Grrr...

>> +#define DEBUG
>> +
> 
> This probably shouldn't be on by default?

For now, I want it on.

> In general, it'd be a bit easier to review the changes you're making if
> you were able to submit individual changes in separate patches, 

Yes, that would be nice :-)

> though I
> appreciate that at the minute you're making a lot of changes that go
> over large portions of the code and can't be easily separated out so I
> wouldn't worry about it too much.

Normally, I would submit everything as one final patch, but I hate hanging on to
uncommitted code for too long.

-- 
Timur Tabi
Linux kernel developer at Freescale