From: Jeff Garzik <jeff@garzik.org>
To: Brian King <brking@linux.vnet.ibm.com>
Cc: James.Bottomley@HansenPartnership.com,
linux-scsi@vger.kernel.org, thlin@linux.vnet.ibm.com,
linux-ide@vger.kernel.org, miltonm@bga.com
Subject: Re: [PATCH 1/1] ipr: Fix HDIO_GET_IDENTITY oops for SATA devices
Date: Mon, 02 Jun 2008 12:08:14 -0400 [thread overview]
Message-ID: <48441AEE.6050605@garzik.org> (raw)
In-Reply-To: <12124164141515-patch-mail.ibm.com>
Brian King wrote:
> Currently, ipr does not support HDIO_GET_IDENTITY to SATA devices.
> An oops occurs if userspace attempts to send the command. Since hald
> issues the command, ensure we fail the ioctl in ipr. This is a
> temporary solution to the oops. Once the ipr libata EH conversion
> is upstream, ipr will fully support HDIO_GET_IDENTITY.
>
> Tested-by: Milton Miller <miltonm@bga.com>
> Signed-off-by: Brian King <brking@linux.vnet.ibm.com>
> ---
>
> linux-2.6-bjking1/drivers/scsi/ipr.c | 6 +++++-
> 1 file changed, 5 insertions(+), 1 deletion(-)
I was pretty happy with the rough draft of your EH conversion... where
does that stand now?
Jeff
next parent reply other threads:[~2008-06-02 16:08 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <12124164141515-patch-mail.ibm.com>
2008-06-02 16:08 ` Jeff Garzik [this message]
2008-06-02 16:27 ` [PATCH 1/1] ipr: Fix HDIO_GET_IDENTITY oops for SATA devices Brian King
2008-06-02 16:45 ` James Bottomley
2008-06-02 17:43 ` Jeff Garzik
2008-06-02 17:57 ` James Bottomley
2008-06-02 18:11 ` Jeff Garzik
2008-06-02 18:51 ` Brian King
2008-06-02 18:54 ` Jeff Garzik
2008-06-02 19:39 ` James Bottomley
2008-06-02 20:27 ` Brian King
2008-06-02 19:35 ` James Bottomley
2008-06-02 19:53 ` Alan Cox
2008-07-11 18:37 Brian King
-- strict thread matches above, loose matches on Subject: below --
2008-06-02 14:20 Brian King
2008-06-02 14:20 Brian King
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=48441AEE.6050605@garzik.org \
--to=jeff@garzik.org \
--cc=James.Bottomley@HansenPartnership.com \
--cc=brking@linux.vnet.ibm.com \
--cc=linux-ide@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=miltonm@bga.com \
--cc=thlin@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.