From mboxrd@z Thu Jan 1 00:00:00 1970 From: Patrick McHardy Subject: Re: [PATCH] Accounting rework: ct_extend + 64bit counters Date: Tue, 03 Jun 2008 19:21:43 +0200 Message-ID: <48457DA7.1080306@trash.net> References: <48442cd8.dD0hLVFRFjNruv6o%ole@ans.pl> <4845477B.8050400@trash.net> <4845712F.7080003@trash.net> <48457414.4050509@trash.net> <48457BE0.6000604@trash.net> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-15; format=flowed Content-Transfer-Encoding: 7bit Cc: netfilter-devel@vger.kernel.org To: Krzysztof Oledzki Return-path: Received: from stinky.trash.net ([213.144.137.162]:46400 "EHLO stinky.trash.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752972AbYFCRVo (ORCPT ); Tue, 3 Jun 2008 13:21:44 -0400 In-Reply-To: Sender: netfilter-devel-owner@vger.kernel.org List-ID: Krzysztof Oledzki wrote: > > > On Tue, 3 Jun 2008, Patrick McHardy wrote: > >> Krzysztof Oledzki wrote: >>>> Mhh good point :) I was thinking of calling it from the raw table, >>>> but of course we don't have a conntrack at that point. So the >>>> information would have to be propagated from the raw table somehow. >>>> Maybe something like the untracked conntrack? IIRC someone posted >>>> a patch for something similar (propagation of parameters to helpers) >>>> some time ago. >>> >>> OK, I'll look at this. Can we push the current version (plus >>> discussed changes) now and tag if for 2.6.27 and try to solve above >>> problem later (2.6.28)? >> >> I would prefer to see a final solution before pushing >> it upstream. Having it only implemented half-way forces >> an additional allocation on everyone (even those not >> even compiling the feature in now) for now gain. > > Not really as my patch makes possible do disable accounting, I even > initially proposed to disable it by default. If accounting is disabled > then there is no additional allocation. Yes, but then I'll get a bunch of bug reports :) And its unlikely that most people will notice or touch this value.