All of lore.kernel.org
 help / color / mirror / Atom feed
From: Avi Kivity <avi@qumranet.com>
To: Amit Shah <amit.shah@qumranet.com>
Cc: "Han, Weidong" <weidong.han@intel.com>,
	kvm@vger.kernel.org, muli@il.ibm.com, benami@il.ibm.com, "Kay,
	Allen M" <allen.m.kay@intel.com>,
	chrisw@redhat.com
Subject: Re: [PATCH 1/1] KVM/userspace: Support for assigning PCI devices to guest
Date: Wed, 04 Jun 2008 17:19:21 +0300	[thread overview]
Message-ID: <4846A469.4020009@qumranet.com> (raw)
In-Reply-To: <200806021341.23106.amit.shah@qumranet.com>

Amit Shah wrote:
> The first option can be enforced by calls to pci_enable_device() and 
> pci_request_regions(). This can solve the problem of assigning multiple 
> devices of the same guest as well.
>   

Yes, that sounds good.

> Dynamically unbinding devices is prone to a lot of errors and assumptions and 
> such policy shouldn't be enforced. We should either fail the assignment and 
> let the administrator take care of doing the right thing and start the guest 
> or just not launch the guest at all.
>   

Agreed.

-- 
Do not meddle in the internals of kernels, for they are subtle and quick to panic.


  reply	other threads:[~2008-06-04 14:19 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-06-02  6:46 [PATCH 1/1] KVM/userspace: Support for assigning PCI devices to guest Amit Shah
2008-06-02  7:18 ` Han, Weidong
2008-06-02  8:11   ` Amit Shah
2008-06-04 14:19     ` Avi Kivity [this message]
2008-06-04 14:43       ` Amit Shah
2008-06-04 14:53         ` Avi Kivity
2008-06-04 15:53           ` Amit Shah
2008-06-04 16:11           ` Muli Ben-Yehuda
2008-06-02 13:57 ` Anthony Liguori
2008-06-02 17:07   ` Amit Shah
2008-06-02 13:58 ` Anthony Liguori
  -- strict thread matches above, loose matches on Subject: below --
2008-07-22 12:13 [PATCH 4/4] KVM: Device assignemnt with VT-d Ben-Ami Yassour
2008-07-22 12:18 ` device assignment - userspace part Ben-Ami Yassour
2008-07-22 12:18   ` [PATCH 1/1] KVM/userspace: Support for assigning PCI devices to guest Ben-Ami Yassour
2008-07-28 16:26 [PATCH 5/5] This patch extends the VT-d driver to support KVM Ben-Ami Yassour
2008-07-28 16:32 ` Device assignment - userspace part Ben-Ami Yassour
2008-07-28 16:32   ` [PATCH 1/1] KVM/userspace: Support for assigning PCI devices to guest Ben-Ami Yassour
2008-08-01  3:09     ` Han, Weidong
2008-08-05  9:41       ` Ben-Ami Yassour

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4846A469.4020009@qumranet.com \
    --to=avi@qumranet.com \
    --cc=allen.m.kay@intel.com \
    --cc=amit.shah@qumranet.com \
    --cc=benami@il.ibm.com \
    --cc=chrisw@redhat.com \
    --cc=kvm@vger.kernel.org \
    --cc=muli@il.ibm.com \
    --cc=weidong.han@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.