All of lore.kernel.org
 help / color / mirror / Atom feed
From: Alexander Graf <agraf@suse.de>
To: qemu-devel@nongnu.org
Subject: [Qemu-devel] [PATCH] VMRUN should store the RIP after the instruction
Date: Wed, 04 Jun 2008 16:56:03 +0200	[thread overview]
Message-ID: <4846AD03.5070908@suse.de> (raw)

[-- Attachment #1: Type: text/plain, Size: 216 bytes --]

VMRUN stores the IP which is used to return to the instruction after the 
VMRUN in case of a VMEXIT. Due to recent changes, this does not happen 
anymore and a VMEXIT simply returns to the VMRUN instruction.

Alex



[-- Attachment #2: qemu-svn-rip.patch --]
[-- Type: text/x-patch, Size: 596 bytes --]

Index: target-i386/op_helper.c
===================================================================
--- target-i386/op_helper.c	(revision 4661)
+++ target-i386/op_helper.c	(working copy)
@@ -4836,7 +4836,7 @@
     svm_save_seg(env->vm_hsave + offsetof(struct vmcb, save.ds), 
                  &env->segs[R_DS]);
 
-    stq_phys(env->vm_hsave + offsetof(struct vmcb, save.rip), EIP);
+    stq_phys(env->vm_hsave + offsetof(struct vmcb, save.rip), EIP + 3);
     stq_phys(env->vm_hsave + offsetof(struct vmcb, save.rsp), ESP);
     stq_phys(env->vm_hsave + offsetof(struct vmcb, save.rax), EAX);
 

             reply	other threads:[~2008-06-04 15:53 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-06-04 14:56 Alexander Graf [this message]
2008-06-04 16:13 ` [Qemu-devel] [PATCH] VMRUN should store the RIP after the instruction Anthony Liguori
2008-06-04 16:19   ` Alexander Graf
2008-06-04 17:56     ` Anthony Liguori

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4846AD03.5070908@suse.de \
    --to=agraf@suse.de \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.