[Qemu-devel] Re: [PATCH 2/2] Enhance sendkey with key hold time

[Jan Kiszka <jan.kiszka@web.de>]

[-- Attachment #1: Type: text/plain, Size: 729 bytes --]

Bernhard Fischer wrote:
> On Wed, Jun 04, 2008 at 12:16:48PM +0200, andrzej zaborowski wrote:
>> On 22/05/2008, Jan Kiszka <jan.kiszka@web.de> wrote:
> 
>>>  +static void release_keys(void *opaque)
>>>  +{
>>>  +    int keycode;
>>>  +
>>>  +    while (nb_pending_keycodes > 0) {
> 
> Perhaps just doing a post decrement on the nb_pending would be cleaner.

I prefer a separate statement for this but...

> 
>>>  +        keycode = keycodes[nb_pending_keycodes-1];
>>>  +        if (keycode & 0x80)
>>>  +            kbd_put_keycode(0xe0);
>>>  +        kbd_put_keycode(keycode | 0x80);
>>>  +        nb_pending_keycodes--;
>>>  +    }

I agree that code reordering can save us the "-1".

Thanks,
Jan


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 254 bytes --]