Re: [PATCH 2/4] knfsd: remove special handling for SIGHUP

[Greg Banks <gnb-cP1dWloDopni96+mSzHFpQC/G2K4zDHf@public.gmane.org>]

Jeff Layton wrote:
> The special handling for SIGHUP in knfsd is a holdover from much
> earlier versions of Linux where reloading the export table was
> more expensive. That facility is not really needed anymore and
> to my knowledge, is seldom-used.
>
> Signed-off-by: Jeff Layton <jlayton@redhat.com>
>   
Acked-by: Greg Banks <gnb-cP1dWloDopni96+mSzHFpQC/G2K4zDHf@public.gmane.org>
> @@ -234,10 +226,9 @@ int nfsd_create_serv(void)
>  	}
>  
>  	atomic_set(&nfsd_busy, 0);
> -	nfsd_serv = svc_create_pooled(&nfsd_program,
> -				      nfsd_max_blksize,
> -				      nfsd_last_thread,
> -				      nfsd, SIG_NOCLEAN, THIS_MODULE);
> +	nfsd_serv = svc_create_pooled(&nfsd_program, nfsd_max_blksize,
> +				      nfsd_last_thread, nfsd, SIGINT,
> +				      THIS_MODULE);
>   
Now that there's no special interpretation of signals, you could
probably also remove the `sig' argument to svc_create_pooled() and the
svc_serv->sv_kill_signal field.

-- 
Greg Banks, P.Engineer, SGI Australian Software Group.
The cake is *not* a lie.
I don't speak for SGI.