From: Stas Sergeev <stsp@aknet.ru>
To: Dmitry Torokhov <dtor-oss@comcast.net>
Cc: Takashi Iwai <tiwai@suse.de>,
Linux kernel <linux-kernel@vger.kernel.org>
Subject: [patch][resend] pcspkr: undepend of snd-pcsp
Date: Thu, 05 Jun 2008 20:48:17 +0400 [thread overview]
Message-ID: <484818D1.3070907@aknet.ru> (raw)
[-- Attachment #1: Type: text/plain, Size: 971 bytes --]
Hello.
It should be possible to build
pcspkr driver together with snd-pcsp.
Even though right now there is no
good plan to get these drivers to
work together, some things were done,
namely:
http://git.kernel.org/?p=linux/kernel/git/torvalds/linux-2.6.git;a=commit;h=16dc42e018c2868211b4928f20a957c0c216126c
and
https://bugzilla.redhat.com/show_bug.cgi?id=448425
which looks more or less sufficient.
And there was a discussion already:
http://kerneltrap.org/mailarchive/linux-kernel/2008/4/29/1652654
(so presumably acked by Takashi)
The attached patch allows pcspkr to
be built together with snd-pcsp.
Dmitry, could you please apply?
------
Allow pcspkr to be built together with snd-pcsp.
The bug in a driver core that prevented this in
the past, is now fixed by
http://git.kernel.org/?p=linux/kernel/git/torvalds/linux-2.6.git;a=commit;h=16dc42e018c2868211b4928f20a957c0c216126c
Signed-off-by: Stas Sergeev <stsp@aknet.ru>
Acked-by: Takashi Iwai <tiwai@suse.de>
[-- Attachment #2: pcspkr_nodep.diff --]
[-- Type: text/x-patch, Size: 401 bytes --]
diff --git a/drivers/input/misc/Kconfig b/drivers/input/misc/Kconfig
index 3ad8bd9..432699d 100644
--- a/drivers/input/misc/Kconfig
+++ b/drivers/input/misc/Kconfig
@@ -15,7 +15,6 @@ if INPUT_MISC
config INPUT_PCSPKR
tristate "PC Speaker support"
depends on PCSPKR_PLATFORM
- depends on SND_PCSP=n
help
Say Y here if you want the standard PC Speaker to be used for
bells and whistles.
next reply other threads:[~2008-06-05 16:48 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-06-05 16:48 Stas Sergeev [this message]
-- strict thread matches above, loose matches on Subject: below --
2008-06-07 17:55 [patch][resend] pcspkr: undepend of snd-pcsp Stas Sergeev
2008-06-07 18:07 ` Dmitry Torokhov
2008-06-07 18:13 ` Stas Sergeev
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=484818D1.3070907@aknet.ru \
--to=stsp@aknet.ru \
--cc=dtor-oss@comcast.net \
--cc=linux-kernel@vger.kernel.org \
--cc=tiwai@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.