From: Mike Christie <michaelc@cs.wisc.edu>
To: device-mapper development <dm-devel@redhat.com>,
SCSI Mailing List <linux-scsi@vger.kernel.org>
Subject: mpath: don't fail paths on first error
Date: Thu, 05 Jun 2008 12:25:31 -0500 [thread overview]
Message-ID: <4848218B.3090404@cs.wisc.edu> (raw)
[-- Attachment #1: Type: text/plain, Size: 1245 bytes --]
The problem we see a lot at Red Hat is that if drivers fail a command
with DID_BUS_BUSY or DID_ERROR for something like underrun or even for
transient path problems, we can normally recover from this pretty
quickly and we do not need to switch path groups.
queue_if_no_path/no_path_retry will prevent IO from being fail upwards,
but just switching paths can cause a lot of strain on the target, so we
might want to prevent path switching when we do not need to. If we are
using a box that requires manual failover or a box that does not use
manual failover but still has to shift resources between storage
controllers when switching paths, we most likely do not want to mark
paths failed for these transient errors.
The attached patch allows us to wait X seconds before marking a path as
failed. If within X seconds from seeing the first IO error, we do not
see a IO complete successfully then we mark a path as failed. This patch
work best with the fail fast enhancements ones where for a lot of path
problems the fast io fail / recovery timeout will fail io quickly to us
and the test IOs do not get stuck, and where some errors like DID_ERROR
are not even failed fast.
The patch should apply over linus's tree or scsi-misc.
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: 0001-dm-mpath-don-t-fail-paths-on-first-error.patch --]
[-- Type: text/x-patch; name="0001-dm-mpath-don-t-fail-paths-on-first-error.patch", Size: 0 bytes --]
[-- Attachment #3: Type: text/plain, Size: 0 bytes --]
next reply other threads:[~2008-06-05 17:25 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-06-05 17:25 Mike Christie [this message]
2008-06-06 14:18 ` mpath: don't fail paths on first error Hannes Reinecke
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4848218B.3090404@cs.wisc.edu \
--to=michaelc@cs.wisc.edu \
--cc=dm-devel@redhat.com \
--cc=linux-scsi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.