From: "Éric Piel" <Eric.Piel@tremplin-utc.net>
To: Jonathan Cameron <jic23@cam.ac.uk>
Cc: Jean Delvare <khali@linux-fr.org>, Andrew Morton <akpm@osdl.org>,
Torokhov <dmitry.torokhov@gmail.com>,
Burman <burman.yan@gmail.com>,
LKML <linux-kernel@vger.kernel.org>,
HWMON <lm-sensors@lm-sensors.org>,
"Mark M. Hoffman" <mhoffman@lightlink.com>,
Pavel Machek <pavel@suse.cz>,
Yan@ATrpms.net, Dmitry@ATrpms.net,
Arjan van de Ven <arjan@infradead.org>
Subject: Re: [lm-sensors] [PATCH 2.6.25.4] hwmon: HP Mobile Data Protection
Date: Thu, 05 Jun 2008 20:34:30 +0000 [thread overview]
Message-ID: <48484DD6.3050706@tremplin-utc.net> (raw)
In-Reply-To: <4847B415.2080708@cam.ac.uk>
05-06-08 11:38, Jonathan Cameron wrote/a écrit:
:
> For an initial bash I'm throwing in a couple of accelerometers, ADC's and
> probably one or two other sensors as well. Haven't come up with a good
> name as yet, but the point is that accelerometers would be just part of
> the relevant subsystem.
>
> Based on one suggestion (and current layout in my source tree),
> drivers/industrialio/accelerometer
> drivers/industrialio/adc
> and crucially for all those weird and wonderful sensors,
> drivers/industrialio/misc
>
> The reason for making it an io system is that many chips combine ADCs and
> DACs. Also suggestions for alternative names would be most welcome.
Great to hear that you have started the new subsystem!
It's also nice that you are still hesitant about the name because
"industrialio" sounds for me too... let's say... industrial ;-) For
accelerometers found in laptops and mobile phones, it will sound strange
(although a name is just a name). Maybe "physicsio" (physics as "the
observation of the matter and its motion")?
> Still, it may take some time to iron out the various kinks in this system
> and get it fully tested, so may be worth putting stuff elsewhere for now
> with the intention to move it as and when the more unified stuff has been
> written.
Yes, so I'll keep my plan of first submitting the driver with the
current interface, and latter updating the interface to the new
subsystem when you have stabilised its interface.
BTW, just by curiosity, is your tree available publicly somewhere?
> Also, the LI3L02DQ (very similar to the chip you are using) is one of my
> test chips, so combining the two drivers should be straight forward.
> Also the driver I have is SPI only, so this may give us an easy way to
> test a combined driver.
For now I'll go back to the drawing board (with Yan) in order to address
the comments received, all very insightful. I'll also go around the
other versions of the driver to pick up the nice parts. Looking at the
openmoko driver, I finally understood how to avoid polling. It will
likely be worthy :-)
In addition, I'll try to make the main functions as independent as
possible of the platform, hoping that we can then easily merge the SPI
and the ACPI versions together.
See you,
Eric
_______________________________________________
lm-sensors mailing list
lm-sensors@lm-sensors.org
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors
WARNING: multiple messages have this Message-ID (diff)
From: "Éric Piel" <Eric.Piel@tremplin-utc.net>
To: Jonathan Cameron <jic23@cam.ac.uk>
Cc: Jean Delvare <khali@linux-fr.org>, Andrew Morton <akpm@osdl.org>,
Torokhov <dmitry.torokhov@gmail.com>,
Burman <burman.yan@gmail.com>,
LKML <linux-kernel@vger.kernel.org>,
HWMON <lm-sensors@lm-sensors.org>,
"Mark M. Hoffman" <mhoffman@lightlink.com>,
Pavel Machek <pavel@suse.cz>,
Yan@ATrpms.net, Dmitry@ATrpms.net,
Arjan van de Ven <arjan@infradead.org>
Subject: Re: [lm-sensors] [PATCH 2.6.25.4] hwmon: HP Mobile Data Protection System 3D ACPI driver -- please review!
Date: Thu, 05 Jun 2008 22:34:30 +0200 [thread overview]
Message-ID: <48484DD6.3050706@tremplin-utc.net> (raw)
In-Reply-To: <4847B415.2080708@cam.ac.uk>
05-06-08 11:38, Jonathan Cameron wrote/a écrit:
:
> For an initial bash I'm throwing in a couple of accelerometers, ADC's and
> probably one or two other sensors as well. Haven't come up with a good
> name as yet, but the point is that accelerometers would be just part of
> the relevant subsystem.
>
> Based on one suggestion (and current layout in my source tree),
> drivers/industrialio/accelerometer
> drivers/industrialio/adc
> and crucially for all those weird and wonderful sensors,
> drivers/industrialio/misc
>
> The reason for making it an io system is that many chips combine ADCs and
> DACs. Also suggestions for alternative names would be most welcome.
Great to hear that you have started the new subsystem!
It's also nice that you are still hesitant about the name because
"industrialio" sounds for me too... let's say... industrial ;-) For
accelerometers found in laptops and mobile phones, it will sound strange
(although a name is just a name). Maybe "physicsio" (physics as "the
observation of the matter and its motion")?
> Still, it may take some time to iron out the various kinks in this system
> and get it fully tested, so may be worth putting stuff elsewhere for now
> with the intention to move it as and when the more unified stuff has been
> written.
Yes, so I'll keep my plan of first submitting the driver with the
current interface, and latter updating the interface to the new
subsystem when you have stabilised its interface.
BTW, just by curiosity, is your tree available publicly somewhere?
> Also, the LI3L02DQ (very similar to the chip you are using) is one of my
> test chips, so combining the two drivers should be straight forward.
> Also the driver I have is SPI only, so this may give us an easy way to
> test a combined driver.
For now I'll go back to the drawing board (with Yan) in order to address
the comments received, all very insightful. I'll also go around the
other versions of the driver to pick up the nice parts. Looking at the
openmoko driver, I finally understood how to avoid polling. It will
likely be worthy :-)
In addition, I'll try to make the main functions as independent as
possible of the platform, hoping that we can then easily merge the SPI
and the ACPI versions together.
See you,
Eric
next prev parent reply other threads:[~2008-06-05 20:34 UTC|newest]
Thread overview: 54+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-05-31 12:05 [lm-sensors] [PATCH 2.6.25.4] hwmon: HP Mobile Data Protection Yan Burman
2008-05-31 12:05 ` [PATCH 2.6.25.4] hwmon: HP Mobile Data Protection System 3D ACPI driver Yan Burman
2008-06-04 19:24 ` [lm-sensors] [PATCH 2.6.25.4] hwmon: HP Mobile Data Protection Éric Piel
2008-06-04 19:24 ` [PATCH 2.6.25.4] hwmon: HP Mobile Data Protection System 3D ACPI driver -- please review! Éric Piel
2008-06-04 20:58 ` [lm-sensors] [PATCH 2.6.25.4] hwmon: HP Mobile Data Protection Jean Delvare
2008-06-04 20:58 ` [PATCH 2.6.25.4] hwmon: HP Mobile Data Protection System 3D ACPI driver -- please review! Jean Delvare
2008-06-04 22:57 ` [lm-sensors] [PATCH 2.6.25.4] hwmon: HP Mobile Data Protection Éric Piel
2008-06-04 22:57 ` [PATCH 2.6.25.4] hwmon: HP Mobile Data Protection System 3D ACPI driver -- please review! Éric Piel
2008-06-05 6:27 ` [lm-sensors] [PATCH 2.6.25.4] hwmon: HP Mobile Data Protection Jean Delvare
2008-06-05 6:27 ` [PATCH 2.6.25.4] hwmon: HP Mobile Data Protection System 3D ACPI driver -- please review! Jean Delvare
2008-06-04 23:05 ` [lm-sensors] [PATCH 2.6.25.4] hwmon: HP Mobile Data Protection Pavel Machek
2008-06-04 23:05 ` [PATCH 2.6.25.4] hwmon: HP Mobile Data Protection System 3D ACPI driver -- please review! Pavel Machek
2008-06-04 23:43 ` [lm-sensors] [PATCH 2.6.25.4] hwmon: HP Mobile Data Protection Éric Piel
2008-06-04 23:43 ` [PATCH 2.6.25.4] hwmon: HP Mobile Data Protection System 3D ACPI driver -- please review! Éric Piel
2008-06-05 6:29 ` [lm-sensors] [PATCH 2.6.25.4] hwmon: HP Mobile Data Protection Jean Delvare
2008-06-05 6:29 ` [PATCH 2.6.25.4] hwmon: HP Mobile Data Protection System 3D ACPI driver -- please review! Jean Delvare
2008-06-05 9:38 ` [lm-sensors] [PATCH 2.6.25.4] hwmon: HP Mobile Data Protection Jonathan Cameron
2008-06-05 9:38 ` [lm-sensors] [PATCH 2.6.25.4] hwmon: HP Mobile Data Protection System 3D ACPI driver -- please review! Jonathan Cameron
2008-06-05 20:34 ` Éric Piel [this message]
2008-06-05 20:34 ` Éric Piel
2008-06-05 22:27 ` Pau Oliva Fora
2008-06-06 14:24 ` [lm-sensors] [PATCH 2.6.25.4] hwmon: HP Mobile Data Dmitry Torokhov
2008-06-06 14:24 ` [lm-sensors] [PATCH 2.6.25.4] hwmon: HP Mobile Data Protection System 3D ACPI driver -- please review! Dmitry Torokhov
2008-06-06 15:29 ` [lm-sensors] [PATCH 2.6.25.4] hwmon: HP Mobile Data Protection Pau Oliva Fora
2008-06-06 15:29 ` [lm-sensors] [PATCH 2.6.25.4] hwmon: HP Mobile Data Protection System 3D ACPI driver -- please review! Pau Oliva Fora
2008-06-06 14:56 ` [lm-sensors] [PATCH 2.6.25.4] hwmon: HP Mobile Data Protection Eric Piel
2008-06-06 14:56 ` [lm-sensors] [PATCH 2.6.25.4] hwmon: HP Mobile Data Protection System 3D ACPI driver -- please review! Eric Piel
2008-06-06 15:30 ` [lm-sensors] [PATCH 2.6.25.4] hwmon: HP Mobile Data Protection Pau Oliva Fora
2008-06-06 15:30 ` [lm-sensors] [PATCH 2.6.25.4] hwmon: HP Mobile Data Protection System 3D ACPI driver -- please review! Pau Oliva Fora
2008-06-06 8:51 ` [lm-sensors] [PATCH 2.6.25.4] hwmon: HP Mobile Data Protection Jonathan Cameron
2008-06-06 8:51 ` [lm-sensors] [PATCH 2.6.25.4] hwmon: HP Mobile Data Protection System 3D ACPI driver -- please review! Jonathan Cameron
2008-06-04 23:03 ` [lm-sensors] [PATCH 2.6.25.4] hwmon: HP Mobile Data Protection Pavel Machek
2008-06-04 23:03 ` [PATCH 2.6.25.4] hwmon: HP Mobile Data Protection System 3D ACPI driver -- please review! Pavel Machek
2008-06-04 23:29 ` [lm-sensors] [PATCH 2.6.25.4] hwmon: HP Mobile Data Protection Éric Piel
2008-06-04 23:29 ` [PATCH 2.6.25.4] hwmon: HP Mobile Data Protection System 3D ACPI driver -- please review! Éric Piel
2008-06-05 1:06 ` [lm-sensors] [PATCH 2.6.25.4] hwmon: HP Mobile Data Protection Henrique de Moraes Holschuh
2008-06-05 1:06 ` [PATCH 2.6.25.4] hwmon: HP Mobile Data Protection System 3D ACPI driver -- please review! Henrique de Moraes Holschuh
2008-06-05 8:19 ` [lm-sensors] [PATCH 2.6.25.4] hwmon: HP Mobile Data Protection Pavel Machek
2008-06-05 8:19 ` [PATCH 2.6.25.4] hwmon: HP Mobile Data Protection System 3D ACPI driver -- please review! Pavel Machek
2008-06-06 14:27 ` [lm-sensors] [PATCH 2.6.25.4] hwmon: HP Mobile Data Protection Dmitry Torokhov
2008-06-06 14:27 ` [PATCH 2.6.25.4] hwmon: HP Mobile Data Protection System 3D ACPI driver -- please review! Dmitry Torokhov
2008-06-06 14:59 ` [lm-sensors] [PATCH 2.6.25.4] hwmon: HP Mobile Data Protection Eric Piel
2008-06-06 14:59 ` [PATCH 2.6.25.4] hwmon: HP Mobile Data Protection System 3D ACPI driver -- please review! Eric Piel
2008-06-06 15:11 ` [lm-sensors] [PATCH 2.6.25.4] hwmon: HP Mobile Data Protection Dmitry Torokhov
2008-06-06 15:11 ` [PATCH 2.6.25.4] hwmon: HP Mobile Data Protection System 3D ACPI driver -- please review! Dmitry Torokhov
2008-06-06 15:37 ` [lm-sensors] [PATCH 2.6.25.4] hwmon: HP Mobile Data Protection Pau Oliva Fora
2008-06-06 15:37 ` [PATCH 2.6.25.4] hwmon: HP Mobile Data Protection System 3D ACPI driver -- please review! Pau Oliva Fora
2008-06-05 5:17 ` [lm-sensors] [PATCH 2.6.25.4] hwmon: HP Mobile Data Protection Andrew Morton
2008-06-05 5:17 ` [PATCH 2.6.25.4] hwmon: HP Mobile Data Protection System 3D ACPI driver Andrew Morton
2008-06-05 7:43 ` [lm-sensors] " Riku Voipio
2008-06-05 7:43 ` [lm-sensors] [PATCH 2.6.25.4] hwmon: HP Mobile Data Protection Riku Voipio
[not found] ` <48479922.6050003-WgUW+8SLYMv1KXRcyAk9cg@public.gmane.org>
2008-06-05 8:28 ` [lm-sensors] [PATCH 2.6.25.4] hwmon: HP Mobile Data Protection System 3D ACPI driver Eric Piel
2008-06-05 8:28 ` Eric Piel
2008-06-05 8:28 ` [lm-sensors] [PATCH 2.6.25.4] hwmon: HP Mobile Data Protection Eric Piel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=48484DD6.3050706@tremplin-utc.net \
--to=eric.piel@tremplin-utc.net \
--cc=Dmitry@ATrpms.net \
--cc=Yan@ATrpms.net \
--cc=akpm@osdl.org \
--cc=arjan@infradead.org \
--cc=burman.yan@gmail.com \
--cc=dmitry.torokhov@gmail.com \
--cc=jic23@cam.ac.uk \
--cc=khali@linux-fr.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lm-sensors@lm-sensors.org \
--cc=mhoffman@lightlink.com \
--cc=pavel@suse.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.