From: Balbir Singh <balbir@linux.vnet.ibm.com>
To: Li Zefan <lizf@cn.fujitsu.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
Paul Menage <menage@google.com>,
KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>,
LKML <linux-kernel@vger.kernel.org>,
"linux-mm@kvack.org" <linux-mm@kvack.org>
Subject: Re: [PATCH] memcg: clean up checking of the disabled flag
Date: Fri, 06 Jun 2008 07:25:11 +0530 [thread overview]
Message-ID: <484898FF.4040701@linux.vnet.ibm.com> (raw)
In-Reply-To: <4848955D.2020302@cn.fujitsu.com>
Li Zefan wrote:
> Those checks are unnecessary, because when the subsystem is disabled
> it can't be mounted, so those functions won't get called.
>
> The check is needed in functions which will be called in other places
> except cgroup.
>
> Signed-off-by: Li Zefan <lizf@cn.fujitsu.com>
Yep, that should work
Acked-by: Balbir Singh <balbir@linux.vnet.ibm.com>
--
Warm Regards,
Balbir Singh
Linux Technology Center
IBM, ISTL
WARNING: multiple messages have this Message-ID (diff)
From: Balbir Singh <balbir@linux.vnet.ibm.com>
To: Li Zefan <lizf@cn.fujitsu.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
Paul Menage <menage@google.com>,
KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>,
LKML <linux-kernel@vger.kernel.org>,
"linux-mm@kvack.org" <linux-mm@kvack.org>
Subject: Re: [PATCH] memcg: clean up checking of the disabled flag
Date: Fri, 06 Jun 2008 07:25:11 +0530 [thread overview]
Message-ID: <484898FF.4040701@linux.vnet.ibm.com> (raw)
In-Reply-To: <4848955D.2020302@cn.fujitsu.com>
Li Zefan wrote:
> Those checks are unnecessary, because when the subsystem is disabled
> it can't be mounted, so those functions won't get called.
>
> The check is needed in functions which will be called in other places
> except cgroup.
>
> Signed-off-by: Li Zefan <lizf@cn.fujitsu.com>
Yep, that should work
Acked-by: Balbir Singh <balbir@linux.vnet.ibm.com>
--
Warm Regards,
Balbir Singh
Linux Technology Center
IBM, ISTL
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2008-06-06 1:56 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-06-06 1:39 [PATCH] memcg: clean up checking of the disabled flag Li Zefan
2008-06-06 1:39 ` Li Zefan
2008-06-06 1:55 ` Balbir Singh [this message]
2008-06-06 1:55 ` Balbir Singh
2008-06-06 1:55 ` KAMEZAWA Hiroyuki
2008-06-06 1:55 ` KAMEZAWA Hiroyuki
2008-06-07 6:47 ` KOSAKI Motohiro
2008-06-07 6:47 ` KOSAKI Motohiro
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=484898FF.4040701@linux.vnet.ibm.com \
--to=balbir@linux.vnet.ibm.com \
--cc=akpm@linux-foundation.org \
--cc=kamezawa.hiroyu@jp.fujitsu.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=lizf@cn.fujitsu.com \
--cc=menage@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.