All of lore.kernel.org
 help / color / mirror / Atom feed
From: Sergei Poselenov <sposelenov@emcraft.com>
To: u-boot@lists.denx.de
Subject: [U-Boot-Users] [PATCH 07/08] Socrates: NAND support added. Changed the U-Boot base address and
Date: Sat, 07 Jun 2008 19:02:59 +0400	[thread overview]
Message-ID: <484AA323.90903@emcraft.com> (raw)
In-Reply-To: <59b21cf20806070514m37106f13h26f1a7ebacd85cf2@mail.gmail.com>

Hello,

>> +#include <asm/io.h>
>> +
>> +int state;
> 
> Can that variable be made static?
> 
> Regards, Magnus
> 

Yes, it can.

Wolfgang, what is the best way to handle this? Should I re-do the
patch?

Regards,
Sergei

  reply	other threads:[~2008-06-07 15:02 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-06-06 13:42 [U-Boot-Users] [PATCH 0/8] Updates for "socrates" board Wolfgang Denk
2008-06-06 13:42 ` [U-Boot-Users] [PATCH 01/08] Socrates: Fixed PCI bus frequency report Wolfgang Denk
2008-06-06 13:42   ` [U-Boot-Users] [PATCH 02/08] Socrates: config file cleanup Wolfgang Denk
2008-06-06 13:42     ` [U-Boot-Users] [PATCH 03/08] Added the upmconfig() function for 85xx Wolfgang Denk
2008-06-06 13:42       ` [U-Boot-Users] [PATCH 04/08] Socrates: Added FPGA mapping. LAWs and TLBs cleanup Wolfgang Denk
2008-06-06 13:42         ` [U-Boot-Users] [PATCH 05/08] Socrates: added missed file with UPMA configuration data Wolfgang Denk
2008-06-06 13:42           ` [U-Boot-Users] [PATCH 06/08] NAND: Added support for 128-bit OOB, adapted Wolfgang Denk
2008-06-06 13:42             ` [U-Boot-Users] [PATCH 07/08] Socrates: NAND support added. Changed the U-Boot base address and Wolfgang Denk
2008-06-06 13:42               ` [U-Boot-Users] [PATCH 08/08] Socrates: Added FPGA base address update in FDT Wolfgang Denk
2008-06-07 12:14               ` [U-Boot-Users] [PATCH 07/08] Socrates: NAND support added. Changed the U-Boot base address and Magnus Lilja
2008-06-07 15:02                 ` Sergei Poselenov [this message]
2008-06-10 23:45                   ` Andy Fleming

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=484AA323.90903@emcraft.com \
    --to=sposelenov@emcraft.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.