From: James Chapman <jchapman@katalix.com>
To: Herbert Xu <herbert@gondor.apana.org.au>
Cc: "David S. Miller" <davem@davemloft.net>, netdev@vger.kernel.org
Subject: Re: pppoe: Unshare skb before anything else
Date: Sun, 08 Jun 2008 11:08:59 +0100 [thread overview]
Message-ID: <484BAFBB.6010108@katalix.com> (raw)
In-Reply-To: <20080608062913.GA20871@gondor.apana.org.au>
Herbert Xu wrote:
> Hi Dave:
>
> I noticed that my last patch to move the unshare in pppoe missed
> the other spot which did the same thing:
>
> pppoe: Unshare skb before anything else
>
> We need to unshare the skb first as otherwise pskb_may_pull may
> write to a shared skb which could be bad.
The same problem exists in the pppol2tp driver. Patch to follow. I'm
also fixing the copy-to-iovec issue.
--
James Chapman
Katalix Systems Ltd
http://www.katalix.com
Catalysts for your Embedded Linux software development
next prev parent reply other threads:[~2008-06-08 10:09 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-06-08 6:29 pppoe: Unshare skb before anything else Herbert Xu
2008-06-08 10:08 ` James Chapman [this message]
2008-06-10 21:09 ` David Miller
2008-06-10 21:44 ` James Chapman
2008-06-10 22:01 ` David Miller
2008-06-10 21:08 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=484BAFBB.6010108@katalix.com \
--to=jchapman@katalix.com \
--cc=davem@davemloft.net \
--cc=herbert@gondor.apana.org.au \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.