All of lore.kernel.org
 help / color / mirror / Atom feed
From: Rene Herman <rene.herman@keyaccess.nl>
To: Krzysztof Helt <krzysztof.h1@poczta.fm>
Cc: Takashi Iwai <tiwai@suse.de>, Alsa-devel <alsa-devel@alsa-project.org>
Subject: Re: [PATCH] opti93x: fix sound ouput for Opti930
Date: Sun, 08 Jun 2008 22:29:03 +0200	[thread overview]
Message-ID: <484C410F.2090701@keyaccess.nl> (raw)
In-Reply-To: <20080608075753.6e55b6ba.krzysztof.h1@poczta.fm>

On 08-06-08 07:57, Krzysztof Helt wrote:

> From: Krzysztof Helt <krzysztof.h1@wp.pl>
> 
> This patch fixes silenced output from the Opti930.
> 
> Signed-off-by: Krzysztof Helt <krzysztof.h1@wp.pl>
> 
> ---
> The bug was introduced by me in the patch which added 
> QS1000 wavetable support:
> 
> http://git.kernel.org/?p=linux/kernel/git/torvalds/linux-2.6.git;a=commit;h=f81b953d43c2c12f617da3ecec25e04b5c9e6eb2
> 
> Simply do not change digital input bits on Opti930.

Oh, right, that was it:

http://mailman.alsa-project.org/pipermail/alsa-devel/2008-February/005898.html

I've tested that sound is back after this patch on my 930 as well:

Acked-by: Rene Herman <rene.herman@gmail.com>

I did experience a few instances where the 930 produced nothing but 
static after adjusting its mixer down but this is not going to have 
anything to do with this patch. Mentioned just in case you're now 
looking at a 930 and seeing similar things -- it's not just your card in 
that case...

Rene.

  reply	other threads:[~2008-06-08 20:29 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-06-08  5:57 [PATCH] opti93x: fix sound ouput for Opti930 Krzysztof Helt
2008-06-08 20:29 ` Rene Herman [this message]
2008-06-09 16:36   ` Takashi Iwai

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=484C410F.2090701@keyaccess.nl \
    --to=rene.herman@keyaccess.nl \
    --cc=alsa-devel@alsa-project.org \
    --cc=krzysztof.h1@poczta.fm \
    --cc=tiwai@suse.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.