From: "H. Peter Anvin" <hpa@zytor.com>
To: OGAWA Hirofumi <hirofumi@mail.parknet.co.jp>
Cc: "H. Peter Anvin" <hpa@kernel.org>,
"Adrian Bunk" <bunk@kernel.org>,
"\"S.Çağlar Onur\"" <caglar@pardus.org.tr>,
linux-kernel@vger.kernel.org,
"Linus Torvalds" <torvalds@linux-foundation.org>,
"Frank Seidel" <fseidel@suse.de>,
"Onur Küçük" <onur@pardus.org.tr>,
"Andrew Morton" <akpm@linux-foundation.org>
Subject: Re: [2.6.26 patch] fat_valid_media() isn't for userspace
Date: Sun, 08 Jun 2008 21:41:25 -0700 [thread overview]
Message-ID: <484CB475.7070707@zytor.com> (raw)
In-Reply-To: <87iqwjmekq.fsf@duaron.myhome.or.jp>
OGAWA Hirofumi wrote:
>>
>> We need to make this either __kernel_dirent_t[*] or something like
>> struct __msdos_fs_dirent.
>
> I see. "struct dirent" in linux/dirent.h has very few users in kernel,
> and probably userland doesn't use it, so it seems it should be renamed.
>
> Well, the patch is like this (sorry, other cleanup is in this patch)?
> BTW, does typedef help it in this case?
>
If we're using a FAT-specific structure, then no, there is no reason to
use a typedef.
-hpa
next prev parent reply other threads:[~2008-06-09 4:59 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-06-08 18:16 [PATCH] include/linux/msdos_fs.h: Cleanup include/linux/msdos_fs.h for userspace S.Çağlar Onur
2008-06-08 18:36 ` OGAWA Hirofumi
2008-06-08 18:43 ` [2.6.26 patch] fat_valid_media() isn't " Adrian Bunk
2008-06-08 18:55 ` OGAWA Hirofumi
2008-06-09 1:14 ` H. Peter Anvin
2008-06-09 4:12 ` OGAWA Hirofumi
2008-06-09 4:41 ` H. Peter Anvin [this message]
2008-06-09 8:05 ` Adrian Bunk
2008-06-09 22:26 ` [2.6 patch] fat/dir.c: switch to struct __fat_fs_dirent Adrian Bunk
2008-06-09 23:12 ` OGAWA Hirofumi
2008-06-09 22:27 ` [2.6 patch] remove the in-kernel struct dirent{,64} Adrian Bunk
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=484CB475.7070707@zytor.com \
--to=hpa@zytor.com \
--cc=akpm@linux-foundation.org \
--cc=bunk@kernel.org \
--cc=caglar@pardus.org.tr \
--cc=fseidel@suse.de \
--cc=hirofumi@mail.parknet.co.jp \
--cc=hpa@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=onur@pardus.org.tr \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.