All of lore.kernel.org
 help / color / mirror / Atom feed
From: Andreas Ericsson <ae@op5.se>
To: Miklos Vajna <vmiklos@frugalware.org>
Cc: git@vger.kernel.org
Subject: Re: [PATCH 07/10] git-fmt-merge-msg: make it useable from other builtins
Date: Mon, 09 Jun 2008 10:58:28 +0200	[thread overview]
Message-ID: <484CF0B4.6000102@op5.se> (raw)
In-Reply-To: <2e4b20178405cf993ce9e0f1ffe4ac402a96fd03.1212698317.git.vmiklos@frugalware.org>

Miklos Vajna wrote:
> Move all functionality (except config and option parsing) from
> cmd_fmt_merge_msg() to fmt_merge_msg(), so that other builtins can use
> it without a child process.
> 
> All functions have been changed to use strbufs, and now only
> cmd_fmt_merge_msg() reads directly from a file / writes anything to
> stdout.
> 

I have a very nearly identical patch in an ancient offshoot branch
since my attempt to make git-pull a builtin (which was stupid as
it doesn't do anything CPU-intensive apart from merging).

I likes it. For bonus points you could replace some strbuf_addf()
calls with strbuf_addstr() ones, but I don't think anyone really
cares.

So, fwiw,
Liked-by: Andreas Ericsson <ae@op5.se>

-- 
Andreas Ericsson                   andreas.ericsson@op5.se
OP5 AB                             www.op5.se
Tel: +46 8-230225                  Fax: +46 8-230231

  parent reply	other threads:[~2008-06-09  8:59 UTC|newest]

Thread overview: 45+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-06-05 20:44 [PATCH 00/10] Build in merge Miklos Vajna
2008-06-05 20:44 ` [PATCH 01/10] Move split_cmdline() to alias.c Miklos Vajna
2008-06-05 20:44 ` [PATCH 02/10] Move commit_list_count() to commit.c Miklos Vajna
2008-06-05 20:44 ` [PATCH 03/10] Move builtin-remote's skip_prefix() to git-compat-util.h Miklos Vajna
2008-06-05 22:38   ` Junio C Hamano
2008-06-06 23:42     ` [PATCH] Move parse-options's " Miklos Vajna
2008-06-05 20:44 ` [PATCH 04/10] Add new test to ensure git-merge handles pull.twohead and pull.octopus Miklos Vajna
2008-06-05 22:58   ` Junio C Hamano
2008-06-07  0:47     ` [PATCH] " Miklos Vajna
2008-06-05 20:44 ` [PATCH 05/10] parseopt: add a new PARSE_OPT_ARGV0_IS_AN_OPTION option Miklos Vajna
2008-06-05 20:44 ` [PATCH 06/10] Move read_cache_unmerged() to read-cache.c Miklos Vajna
2008-06-05 23:05   ` Junio C Hamano
2008-06-07  1:00     ` [PATCH] " Miklos Vajna
2008-06-05 20:44 ` [PATCH 07/10] git-fmt-merge-msg: make it useable from other builtins Miklos Vajna
2008-06-05 23:12   ` Junio C Hamano
2008-06-07  1:04     ` Miklos Vajna
2008-06-09  8:58   ` Andreas Ericsson [this message]
2008-06-09 22:53     ` [PATCH] git-fmt-merge-msg: make it usable " Miklos Vajna
2008-06-05 20:44 ` [PATCH 08/10] Introduce commit_list_append() in commit.c Miklos Vajna
2008-06-05 23:16   ` Junio C Hamano
2008-06-06 23:52     ` Miklos Vajna
2008-06-07  0:14       ` Junio C Hamano
2008-06-07  2:03         ` Miklos Vajna
2008-06-05 20:44 ` [PATCH 09/10] Introduce get_octopus_merge_bases() " Miklos Vajna
2008-06-06  3:51   ` Junio C Hamano
2008-06-06  5:53     ` Junio C Hamano
2008-06-06 12:28       ` Johannes Schindelin
2008-06-06 12:36         ` Johannes Schindelin
2008-06-06 15:36         ` Junio C Hamano
2008-06-07 21:38       ` [PATCH] " Miklos Vajna
2008-06-09 14:02         ` Johannes Schindelin
2008-06-09 22:43           ` Miklos Vajna
2008-06-09 22:55             ` Junio C Hamano
2008-06-09 23:08               ` Johannes Schindelin
2008-06-09 23:20                 ` Junio C Hamano
2008-06-09 23:35                   ` Miklos Vajna
2008-06-09 23:06             ` Junio C Hamano
2008-06-09 23:25               ` Miklos Vajna
2008-06-09 23:31               ` Johannes Schindelin
2008-06-09 23:41                 ` Junio C Hamano
2008-06-10  0:03                   ` Miklos Vajna
2008-06-10  2:43                     ` Johannes Schindelin
2008-06-06 12:30     ` [PATCH 09/10] " Johannes Schindelin
2008-06-07  2:30     ` Miklos Vajna
2008-06-05 20:44 ` [PATCH 10/10] Build in merge Miklos Vajna

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=484CF0B4.6000102@op5.se \
    --to=ae@op5.se \
    --cc=git@vger.kernel.org \
    --cc=vmiklos@frugalware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.