From: Alexander Graf <agraf@csgraf.de>
To: qemu-devel@nongnu.org
Subject: [Qemu-devel] [PATCH] SVM: Fix segment attribute clobbering
Date: Mon, 09 Jun 2008 14:42:46 +0200 [thread overview]
Message-ID: <484D2546.8090605@csgraf.de> (raw)
[-- Attachment #1: Type: text/plain, Size: 197 bytes --]
When SVM segment flags get stored in the VMCB, there is a certain chance
that they get clobbered by garbage bits. This patch ANDs the wanted bits
correctly and thus makes SVM work again.
Alex
[-- Attachment #2: qemu-svn-segflags.patch --]
[-- Type: text/x-patch, Size: 597 bytes --]
Index: target-i386/op_helper.c
===================================================================
--- target-i386/op_helper.c (revision 4707)
+++ target-i386/op_helper.c (working copy)
@@ -4767,7 +4767,7 @@
stl_phys(addr + offsetof(struct vmcb_seg, limit),
sc->limit);
stw_phys(addr + offsetof(struct vmcb_seg, attrib),
- (sc->flags >> 8) | ((sc->flags >> 12) & 0x0f00));
+ ((sc->flags >> 8) & 0xff) | ((sc->flags >> 12) & 0x0f00));
}
static inline void svm_load_seg(target_phys_addr_t addr, SegmentCache *sc)
reply other threads:[~2008-06-09 12:44 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=484D2546.8090605@csgraf.de \
--to=agraf@csgraf.de \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.