Re: [PATCH 0/2] Improve hpet accuracy

[Dave Winchell <dwinchell@virtualiron.com>]

Keir Fraser wrote:

> On 9/6/08 13:03, "Keir Fraser" <keir.fraser@eu.citrix.com> wrote:
>
>         ok, I'll work on this. How much time do I have to make the
>         release you are
>         working on?
>
>
>     I’m thinking feature freeze at the end of the month.
>
>
> Oh, while I’m commenting on the current version of the patch, I will 
> point out that changes to the save/restore format need careful 
> thought. At the very least we’d like to be backward compatible (old 
> images restore on new Xen) even if we don’t achieve compatibility the 
> other way round. I didn’t really look too closely at this aspect of 
> the patches so perhaps these patches are fine in this regard.

I'll look into the live migrate from old to new.

> Either way I think the core re-architecting of the hpet device model 
> to handle missed ticks and so on is independent of interface changes 
> anyway (apart from reasonable extensions to the timer_mode option). 
> Changes to save/restore format, addition of extra debugging code, and 
> peripheral things like that it’d be nice to have in separate patches. 
> It makes the core stuff easier to review and more likely to get 
> accepted without quibble (because there’s less of it, and it is all 
> dedicated to a single purpose which I think we all agree is where we 
> want to be).

This is fine. I'll break up the patch along the lines you suggest.

>
> Thanks,
> Keir

Thanks,
Dave