All of lore.kernel.org
 help / color / mirror / Atom feed
From: Avi Kivity <avi@qumranet.com>
To: Glauber Costa <gcosta@redhat.com>,
	"Xu, Anthony" <anthony.xu@intel.com>,
	"Zhang, Xiantao" <xiantao.zhang@intel.com>
Cc: kvm@vger.kernel.org, glommer@gmail.com
Subject: Re: [PATCH] do not use extra env field.
Date: Mon, 09 Jun 2008 19:02:52 +0300	[thread overview]
Message-ID: <484D542C.2040708@qumranet.com> (raw)
In-Reply-To: <1212719787-10758-1-git-send-email-gcosta@redhat.com>

Glauber Costa wrote:
> There's no need to polute the already poluted CPUState
> with "ready_for_interrupt_injection". We can compute it
> in the few times we use it, and be fine.
>   

>  #define CPUState CPUIA64State
> diff --git a/qemu/target-ia64/op_helper.c b/qemu/target-ia64/op_helper.c
> index 4969ef7..f582023 100644
> --- a/qemu/target-ia64/op_helper.c
> +++ b/qemu/target-ia64/op_helper.c
> @@ -36,7 +36,6 @@ CPUState *cpu_ia64_init(char *cpu_model){
>      cpu_reset(env);
>      if (kvm_enabled()) {
>  	kvm_qemu_init_env(env);
> -	env->ready_for_interrupt_injection = 1;
>  	kvm_init_new_ap(env->cpu_index, env);
>      }
>      return env;
>   

This bit means that this patch is not an identity transformation.  
Anthony/Xiantao, can you confirm that this patch is safe for ia64?

-- 
Do not meddle in the internals of kernels, for they are subtle and quick to panic.


  reply	other threads:[~2008-06-09 16:02 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-06-06  2:36 [PATCH] do not use extra env field Glauber Costa
2008-06-09 16:02 ` Avi Kivity [this message]
2008-06-11  3:26   ` Xu, Anthony
2008-06-12 12:55     ` Avi Kivity

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=484D542C.2040708@qumranet.com \
    --to=avi@qumranet.com \
    --cc=anthony.xu@intel.com \
    --cc=gcosta@redhat.com \
    --cc=glommer@gmail.com \
    --cc=kvm@vger.kernel.org \
    --cc=xiantao.zhang@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.