All of lore.kernel.org
 help / color / mirror / Atom feed
From: Avi Kivity <avi@qumranet.com>
To: Gerd Hoffmann <kraxel@redhat.com>
Cc: kvm@vger.kernel.org
Subject: Re: Oops for sale
Date: Mon, 09 Jun 2008 19:33:19 +0300	[thread overview]
Message-ID: <484D5B4F.3080300@qumranet.com> (raw)
In-Reply-To: <484D3310.6070908@redhat.com>

Gerd Hoffmann wrote:
> Log attached.  Scanning it and having a brief look at the source code
> makes me suspect it could be a flags update triggering this: Due to
> 64bit xen guest kernels running in ring3 xenner may just flip the user
> bit (off->on) in the page table handler, which is a unusual operation I
> guess ...
>   

The unshadow-on-userspace-access heuristic is broken.  Since it is also 
bad for Xenner, try removing the following lines:

        spte |= PT_WRITABLE_MASK;
        if (user_fault) {
            mmu_unshadow(vcpu->kvm, gfn);
            goto unshadowed;
        }


-- 
Do not meddle in the internals of kernels, for they are subtle and quick to panic.


  parent reply	other threads:[~2008-06-09 16:33 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-06-06 14:01 Oops for sale Gerd Hoffmann
2008-06-06 20:48 ` Avi Kivity
     [not found]   ` <484D3310.6070908@redhat.com>
2008-06-09 16:33     ` Avi Kivity [this message]
2008-06-09 16:54       ` Gerd Hoffmann
2008-06-11  3:02         ` Avi Kivity

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=484D5B4F.3080300@qumranet.com \
    --to=avi@qumranet.com \
    --cc=kraxel@redhat.com \
    --cc=kvm@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.