From: Glauber Costa <gcosta@redhat.com>
To: "Maciej W. Rozycki" <macro@linux-mips.org>
Cc: linux-kernel@vger.kernel.org, akpm@linux-foundation.org,
tglx@linutronix.de, mingo@elte.hu, hugh@veritas.com
Subject: Re: [PATCH 11/15] x86: move enabling of io_apic to prepare_cpus
Date: Mon, 09 Jun 2008 18:02:42 -0300 [thread overview]
Message-ID: <484D9A72.4010004@redhat.com> (raw)
In-Reply-To: <Pine.LNX.4.55.0806092058550.26593@cliff.in.clinika.pl>
Maciej W. Rozycki wrote:
> On Mon, 9 Jun 2008, Glauber Costa wrote:
>
>> This one does enable_IO_APIC in the init_uniprocessor too, and should
>> account for the !smp case.
>
> Hmm, it looks a little bit better, but why do you want to call
> enable_IO_APIC() separately in the first place? There is a comment
> stating: "Enable IO APIC before setting up error vector," but why is it
> needed on 64-bit systems? Especially as the very same system may run a
> 32-bit kernel and then it suddenly would not have to do this anymore?
> Strange...
This was reported by Yinghai, but I think he already answered to that.
> Also since you are cleaning up this code -- why don't you actually take
> the opportunity and get rid of the horrible #ifdefs interspersed
> throughout?
throughout where?
They're all over the place ;)
My next target would be per-cpu data. But that's because there's _a lot_
of code in the tree that got ifdefs between 32 and 64-bit because of
differences in that, specially irq statistics. A macro would do, but if
we're gonna do it, let's do it right.
next prev parent reply other threads:[~2008-06-09 21:07 UTC|newest]
Thread overview: 38+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-06-09 14:16 [PATCH 0/15] Improve x86 smpboot integration Glauber Costa
2008-06-09 14:16 ` [PATCH 01/15] x86: use stack_start in x86_64 Glauber Costa
2008-06-09 14:16 ` [PATCH 02/15] x86: don't use gdt_page openly Glauber Costa
2008-06-09 14:16 ` [PATCH 03/15] x86: remove early_gdt_descr reference Glauber Costa
2008-06-09 14:16 ` [PATCH 04/15] x86: move x86_64 gdt closer to i386 Glauber Costa
2008-06-09 14:16 ` [PATCH 05/15] x86: use initial_code for i386 Glauber Costa
2008-06-09 14:16 ` [PATCH 06/15] x86: boot secondary cpus through initial_code Glauber Costa
2008-06-09 14:16 ` [PATCH 07/15] x86: clearing io_apic harmless for x86_64 Glauber Costa
2008-06-09 14:16 ` [PATCH 08/15] x86: remove ifdef from stepping Glauber Costa
2008-06-09 14:16 ` [PATCH 09/15] x86: change __setup_vector_irq with setup_vector_irq Glauber Costa
2008-06-09 14:16 ` [PATCH 10/15] x86: provide connect_bsp_APIC for x86_64 Glauber Costa
2008-06-09 14:16 ` [PATCH 11/15] x86: move enabling of io_apic to prepare_cpus Glauber Costa
2008-06-09 14:16 ` [PATCH 12/15] x86: change naming to match x86_64 Glauber Costa
2008-06-09 14:16 ` [PATCH 13/15] x86: remove cpu from maps Glauber Costa
2008-06-09 14:16 ` [PATCH 14/15] x86: move cpu_exit_clear to process_32.c Glauber Costa
2008-06-09 14:16 ` [PATCH 15/15] x86: take load_sp0 out of smpboot.c Glauber Costa
2008-06-09 15:23 ` [PATCH 11/15] x86: move enabling of io_apic to prepare_cpus Maciej W. Rozycki
2008-06-09 15:52 ` Glauber Costa
2008-06-09 19:44 ` Glauber Costa
2008-06-09 20:12 ` Maciej W. Rozycki
2008-06-09 20:53 ` Yinghai Lu
2008-06-09 21:00 ` Maciej W. Rozycki
2008-06-10 2:46 ` Maciej W. Rozycki
2008-06-10 5:08 ` Yinghai Lu
2008-06-10 13:00 ` Glauber Costa
2008-06-10 13:30 ` Maciej W. Rozycki
2008-06-10 19:09 ` Yinghai Lu
2008-06-10 19:36 ` Maciej W. Rozycki
2008-06-10 19:49 ` Yinghai Lu
2008-06-11 0:29 ` Maciej W. Rozycki
2008-06-11 2:32 ` Yinghai Lu
2008-06-11 12:57 ` Maciej W. Rozycki
2008-06-09 21:02 ` Glauber Costa [this message]
2008-06-09 15:23 ` [PATCH 03/15] x86: remove early_gdt_descr reference James Bottomley
2008-06-09 15:49 ` Glauber Costa
2008-06-09 17:20 ` James Bottomley
2008-06-09 17:23 ` Glauber Costa
2008-06-09 17:40 ` James Bottomley
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=484D9A72.4010004@redhat.com \
--to=gcosta@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=hugh@veritas.com \
--cc=linux-kernel@vger.kernel.org \
--cc=macro@linux-mips.org \
--cc=mingo@elte.hu \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.