All of lore.kernel.org
 help / color / mirror / Atom feed
From: Rene Herman <rene.herman@keyaccess.nl>
To: Krzysztof Helt <krzysztof.h1@poczta.fm>
Cc: Alsa-devel <alsa-devel@alsa-project.org>
Subject: Re: [PATCH 2/2] opti93x: use cs4231 lib
Date: Tue, 10 Jun 2008 01:29:16 +0200	[thread overview]
Message-ID: <484DBCCC.5050800@keyaccess.nl> (raw)
In-Reply-To: <20080609230732.cb77724c.krzysztof.h1@poczta.fm>

On 09-06-08 23:07, Krzysztof Helt wrote:

> From: Krzysztof Helt <krzysztof.h1@wp.pl>
> 
> This patch converts the Opti93x driver to use
> the cs4231 library instead of duplicating the code.
> 
> Signed-off-by: Krzysztof Helt <krzysztof.h1@wp.pl>
> 
> ---
> This patch requires the patch which adds opti93x
> support to the cs4231 library. It saves few hundreds LOCs.
> 
> This patch was sent some time ago. It should work
> now on Opti93x.
> 
> The patch was prepared against the 2.6.26-rc5 kernel.
> 
> Tested on Opti 930, 931 and 933.

Tested-by: Rene Herman <rene.herman@gmail.com>

again also on 930, 931 and 933. As said, good to see this. Only quickly 
scanned the code and didn't immedately see the mixer level issue. Is the 
level difference reproducible at your end or should I investigate further?

Rene.

  reply	other threads:[~2008-06-09 23:29 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-06-09 21:07 [PATCH 2/2] opti93x: use cs4231 lib Krzysztof Helt
2008-06-09 23:29 ` Rene Herman [this message]
2008-06-10  5:40 ` Takashi Iwai
2008-06-10 21:09   ` Krzysztof Helt
2008-06-11 16:20     ` Takashi Iwai

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=484DBCCC.5050800@keyaccess.nl \
    --to=rene.herman@keyaccess.nl \
    --cc=alsa-devel@alsa-project.org \
    --cc=krzysztof.h1@poczta.fm \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.