From: Patrick McHardy <kaber@trash.net>
To: "Waskiewicz Jr, Peter P" <peter.p.waskiewicz.jr@intel.com>
Cc: jeff@garzik.org, davem@davemloft.net, netdev@vger.kernel.org,
Thomas Graf <tgraf@suug.ch>
Subject: Re: [PATCH 1/3] [NET-NEXT]: Add DCB netlink interface definition
Date: Tue, 10 Jun 2008 09:14:09 +0200 [thread overview]
Message-ID: <484E29C1.2010302@trash.net> (raw)
In-Reply-To: <D5C1322C3E673F459512FB59E0DDC3290538B15D@orsmsx414.amr.corp.intel.com>
Waskiewicz Jr, Peter P wrote:
>>> +struct dcbnl_genl_ops {
>>> + u8 (*getstate)(struct net_device *);
>>> + void (*setstate)(struct net_device *, u8);
>>> + void (*getpermhwaddr)(struct net_device *, u8 *);
>> "getpermhwaddr" doesn't seem to belong in this interface but
>> in rtnetlink and/or ethtool instead.
>
> This was a feature in ethtool, but it was removed at some point. I can
> add it to rtnetlink though if people think it'll be useful to have.
I think thats a better idea than to put it in a private
driver interface.
next prev parent reply other threads:[~2008-06-10 7:14 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-05-27 14:13 [PATCH] NET: DCB generic netlink interface PJ Waskiewicz
2008-05-27 14:13 ` [PATCH 1/3] [NET-NEXT]: Add DCB netlink interface definition PJ Waskiewicz
2008-05-28 9:41 ` Thomas Graf
2008-05-28 16:03 ` Waskiewicz Jr, Peter P
2008-05-28 22:37 ` Thomas Graf
2008-06-01 12:16 ` Waskiewicz Jr, Peter P
2008-06-05 13:17 ` Patrick McHardy
2008-06-09 22:11 ` Waskiewicz Jr, Peter P
2008-06-10 7:14 ` Patrick McHardy [this message]
2008-05-27 14:13 ` [PATCH 2/3] ixgbe: Add Data Center Bridging hardware initialization code PJ Waskiewicz
2008-05-27 14:13 ` [PATCH 3/3] ixgbe: Enable Data Center Bridging (DCB) support PJ Waskiewicz
2008-06-04 18:44 ` [PATCH] NET: DCB generic netlink interface David Miller
2008-06-05 6:23 ` Waskiewicz Jr, Peter P
2008-06-05 14:43 ` David Miller
2008-06-05 20:29 ` Thomas Graf
2008-06-10 19:55 ` Waskiewicz Jr, Peter P
2008-06-10 20:07 ` David Miller
2008-06-11 17:51 ` Thomas Graf
2008-06-11 17:50 ` Patrick McHardy
2008-06-11 21:28 ` Thomas Graf
2008-06-12 10:17 ` Patrick McHardy
2008-06-11 18:28 ` Waskiewicz Jr, Peter P
2008-06-11 21:26 ` Thomas Graf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=484E29C1.2010302@trash.net \
--to=kaber@trash.net \
--cc=davem@davemloft.net \
--cc=jeff@garzik.org \
--cc=netdev@vger.kernel.org \
--cc=peter.p.waskiewicz.jr@intel.com \
--cc=tgraf@suug.ch \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.