From mboxrd@z Thu Jan 1 00:00:00 1970 From: Pavel Emelyanov Subject: Re: [RFC PATCH 0/5] memcg: VM overcommit accounting and handling Date: Tue, 10 Jun 2008 11:52:25 +0400 Message-ID: <484E32B9.4020606@openvz.org> References: <1213054383-18137-1-git-send-email-righi.andrea@gmail.com> <20080610091439.04061da9.kamezawa.hiroyu@jp.fujitsu.com> <484E0D73.6010609@linux.vnet.ibm.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <484E0D73.6010609@linux.vnet.ibm.com> Sender: linux-kernel-owner@vger.kernel.org To: Andrea Righi Cc: balbir@linux.vnet.ibm.com, KAMEZAWA Hiroyuki , menage@google.com, kosaki.motohiro@jp.fujitsu.com, linux-kernel@vger.kernel.org, containers@lists.osdl.org List-Id: containers.vger.kernel.org Balbir Singh wrote: > KAMEZAWA Hiroyuki wrote: >> On Tue, 10 Jun 2008 01:32:58 +0200 >> Andrea Righi wrote: >> >>> Provide distinct cgroup VM overcommit accounting and handling using the memory >>> resource controller. >>> >> Could you explain the benefits of this even when we have memrlimit controller ? >> (If unsure, see 2.6.26-rc5-mm1 and search memrlimit controller.) >> >> And this kind of virtual-address-handling things should be implemented on >> memrlimit controller (means not on memory-resource-controller.). >> It seems this patch doesn't need to handle page_group. >> >> Considering hierarchy, putting several kinds of features on one controller is >> not good, I think. Balbir, how do you think ? >> > > I would tend to agree. With the memrlimit controller, can't we do this in user > space now? Figure out the overcommit value and based on that setup the memrlimit? I also agree with Balbir and Kamezawa. Separate controller for VM (i.e. vma-s lengths) is more preferable, rather than yet another fancy feature on top of the existing rss one.