All of lore.kernel.org
 help / color / mirror / Atom feed
From: Marius Storm-Olsen <marius@trolltech.com>
To: Git Mailing List <git@vger.kernel.org>
Subject: 'git format-patch' on older commits, and mailinglist
Date: Tue, 10 Jun 2008 12:09:34 +0200	[thread overview]
Message-ID: <484E52DE.1070100@trolltech.com> (raw)

[-- Attachment #1: Type: text/plain, Size: 1238 bytes --]

Hi,

Recently, I sent out patches which were fixed up with --amend on older 
commits. When I sent them out, the patches contained
     Date: <more than 2 days old datestamp>
in the headers. Now, sending these mails is fine, and mail clients 
generally handles it perfectly fine. However, after doing this I got 
an email from postmaster@vger.kernel.org, basically telling me to not 
do this, since they get a lot of bounces where the return is marked with
     Diagnostic Code: smtp; 550 (4.5 DATE_IN_PAST_48_96 Date: is 48 to 
96 hours before Received: date)

This is understandable. The question is, do we fix the tools to handle 
this, so that emails are always generated with now() date, and the 
commit content contains a tag for the original commit; or do we simply 
say, always send patches to the mailing list with a current timestamp?

Maybe my workflow is incorrect too. I don't mind pointers on this.

I guess rebasing before generating the patch series would have fixed 
this, but I really didn't need to. I simply reset HEAD~2, fixed with 
--amend, then cherry-picked the other on top again; then created the 
patch series.

-- 
.marius
- simply wondering what others on the git mailinglist do..


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 187 bytes --]

             reply	other threads:[~2008-06-10 10:10 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-06-10 10:09 Marius Storm-Olsen [this message]
2008-06-10 22:37 ` 'git format-patch' on older commits, and mailinglist Junio C Hamano

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=484E52DE.1070100@trolltech.com \
    --to=marius@trolltech.com \
    --cc=git@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.