-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 Karl Hasselström wrote: > > Some comments here: > > * By my reading of the docs, the second argument to BZ2File defaults > to 'r' anyway, so you could omit it. > > * We try to use single quotes wherever possible (except when triple > quoting). You're using a mix ... > > * .replace() will happily replace anywhere in the string. Please > consider using stgit.util.strip_suffix() instead. > > And last but not least, it'd be terrific if you'd let me bully you > into adding .gz and .bz2 test cases for t1800-import. :-) > Sigh. Never reply before your second cup of coffee. Updated patch attached. Clark -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.9 (GNU/Linux) Comment: Using GnuPG with Fedora - http://enigmail.mozdev.org iEYEARECAAYFAkhOh7EACgkQqA4JVb61b9c4BgCeJH0GUzQJCDdJ8gx5287KE/KO uTwAoKD7V4JMqHnYmFCg01ij5aBbLDbq =Yy/n -----END PGP SIGNATURE-----