From mboxrd@z Thu Jan 1 00:00:00 1970 From: Patrick McHardy Subject: Re: [PATCH 12/26] IPVS: Extend proto handler debug functions to handle IPv6. Date: Wed, 11 Jun 2008 19:17:14 +0200 Message-ID: <4850089A.2090006@trash.net> References: <1213204329-10973-1-git-send-email-juliusv@google.com> <1213204329-10973-13-git-send-email-juliusv@google.com> Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1213204329-10973-13-git-send-email-juliusv@google.com> Sender: netdev-owner@vger.kernel.org List-ID: Content-Type: text/plain; charset="us-ascii"; format="flowed" To: "Julius R. Volz" Cc: lvs-devel@vger.kernel.org, netdev@vger.kernel.org, horms@verge.net.au, davem@davemloft.net, vbusam@google.com Julius R. Volz wrote: > Extend protocol handler packet debug functions for TCP, UDP, AH and ESP to > handle IPv6. Make the main debug function call either a v4 or v6 version, > depending on the packet protocol version. > The only difference appears to be the address format and header offset. You could save some duplication by using an af-independant address debugging function and add a helper to get the proto offset. Similar to how x_tables and nf_conntrack do it.