All of lore.kernel.org
 help / color / mirror / Atom feed
From: Olivier Marin <dkr+ml.git@free.fr>
To: Pierre Habouzit <madcoder@debian.org>
Cc: git@vger.kernel.org, gitster@pobox.com
Subject: Re: [PATCH] git-rebase -i: have an option for amending the commit message only.
Date: Wed, 11 Jun 2008 20:36:45 +0200	[thread overview]
Message-ID: <48501B3D.3000405@free.fr> (raw)
In-Reply-To: <1213196490-7762-1-git-send-email-madcoder@debian.org>

Hi,

I like the feature and I have just two comments:

Pierre Habouzit a écrit :
>
> +	comment|c)

Is "comment" the right name? I'm not sure, I just ask.

> +		comment_for_reflog comment
> +
> +		mark_action_done
> +		pick_one $sha1 ||
> +			die_with_patch $sha1 "Could not apply $sha1... $rest"
> +		output git commit --no-verify --amend -e -C HEAD

It does not work with an editor that opens in the current terminal
like vi. Just remove "output" should fix the problem, I think.

Olivier.

  parent reply	other threads:[~2008-06-11 18:37 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-06-11 15:01 [PATCH] git-rebase -i: have an option for amending the commit message only Pierre Habouzit
2008-06-11 15:01 ` [PATCH] git-rebase -i: improve help readability Pierre Habouzit
2008-06-11 18:36 ` Olivier Marin [this message]
2008-06-11 22:27   ` [PATCH] git-rebase -i: have an option for amending the commit message only Pierre Habouzit
2008-06-11 22:51     ` Stephan Beyer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=48501B3D.3000405@free.fr \
    --to=dkr+ml.git@free.fr \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    --cc=madcoder@debian.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.