All of lore.kernel.org
 help / color / mirror / Atom feed
From: Tao Ma <tao.ma@oracle.com>
To: ocfs2-devel@oss.oracle.com
Subject: [Ocfs2-devel] [PATCH 3/8] Make ocfs2_lock_allocators generic for extent	allocation.v1
Date: Thu, 12 Jun 2008 09:40:32 +0800	[thread overview]
Message-ID: <48507E90.1080408@oracle.com> (raw)
In-Reply-To: <20080611233108.GN28100@wotan.suse.de>

Hi Mark,
	Thanks for the review.
	I will modify it according to your suggestions.

Mark Fasheh wrote:
> The rest of this looks good. It's a big patch, but it looks good :) The only
> conern I have isn't really with your code per se, but with layout of our
> source files. Alloc.c keeps growing... and growing... and growing... At some
> point it might be worth our while to split things out at least so that we
> have a 'core btree operations' file.
Yes, now alloc.c have more than 6000 lines. And maybe a new file name 
btree.c can be split out from this file that will do the real work of 
btree operation since with my patch, btree now isn't used by inode only. ;)
I will handle this after the xattr patch is committed. Thanks.

Regards,
Tao

  reply	other threads:[~2008-06-12  1:40 UTC|newest]

Thread overview: 31+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-06-05  7:16 [Ocfs2-devel] [PATCH 0/8] ocfs2: Add extended attributes for ocfs2. V1 Tao Ma
2008-06-05  7:24 ` [Ocfs2-devel] [PATCH 7/8] ocfs2: Add extended attributes support. v1 Tiger Yang
2008-06-13  3:22   ` Mark Fasheh
2008-06-16  7:18     ` Tao Ma
2008-06-16 10:22     ` Tiger Yang
2008-06-17 17:59       ` Mark Fasheh
2008-06-18  9:30         ` Tiger Yang
2008-06-17 23:32   ` Mark Fasheh
2008-06-27  7:49     ` Tiger Yang
2008-06-27 18:10       ` Mark Fasheh
2008-06-30  2:53         ` Tao Ma
2008-06-05  7:31 ` [Ocfs2-devel] [PATCH 1/8] Modify ocfs2_num_free_extents for future xattr usage.v1 Tao Ma
2008-06-05  7:32 ` [Ocfs2-devel] [PATCH 2/8] Use ocfs2_extent_list instead of ocfs2_dinode.v1 Tao Ma
2008-06-05  7:32 ` [Ocfs2-devel] [PATCH 3/8] Make ocfs2_lock_allocators generic for extent allocation.v1 Tao Ma
2008-06-11 23:31   ` Mark Fasheh
2008-06-12  1:40     ` Tao Ma [this message]
2008-06-12 23:51       ` Mark Fasheh
2008-06-05  7:33 ` [Ocfs2-devel] [PATCH 4/8] Make extend allocation generic.v1 Tao Ma
2008-06-12 20:59   ` Mark Fasheh
2008-06-13  2:08     ` Tao Ma
2008-06-05  7:33 ` [Ocfs2-devel] [PATCH 5/8] Add xattr header in ocfs2.v1 Tao Ma
2008-06-12 21:21   ` Mark Fasheh
2008-06-13  1:54     ` Tao Ma
2008-06-05  7:34 ` [Ocfs2-devel] [PATCH 6/8] Add extent tree operation for xattr value.v1 Tao Ma
2008-06-12 23:44   ` Mark Fasheh
2008-06-13  1:48     ` Tao Ma
2008-06-13  2:56       ` Mark Fasheh
2008-06-13  3:28         ` Tao Ma
2008-06-13  2:39   ` Mark Fasheh
2008-06-05  7:35 ` [Ocfs2-devel] [PATCH 8/8] Add large numbers of extended attributes support for ocfs2.v1 Tao Ma
2008-06-06  6:26   ` [Ocfs2-devel] [PATCH 8/8] (Imporved)Add " Tao Ma

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=48507E90.1080408@oracle.com \
    --to=tao.ma@oracle.com \
    --cc=ocfs2-devel@oss.oracle.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.