From: Johannes Sixt <j.sixt@viscovery.net>
To: Git Mailing List <git@vger.kernel.org>
Subject: git diff --cc bug
Date: Thu, 12 Jun 2008 13:48:10 +0200 [thread overview]
Message-ID: <48510CFA.3060101@viscovery.net> (raw)
While resolving a conflict, I noticed this output of 'git diff':
@@@ -109,7 -130,8 +114,8 @@@ void CValuesView::UpdateValues...
lvc.mask = LVCF_TEXT;
lvc.pszText = const_cast<LPTSTR>(static_cast<LPCTST...
- m_table.SetColumn(1, &lvc);
+ GetListCtrl().SetColumn(1, &lvc);
+ m_columnTitles[1].id = valuesHeader;
}
@@@ -635,31 -865,171 +641,169 @@@ void CValuesView::EraseVa...
-LRESULT CValuesView::OnOptionsChanged(WPARAM, LPARAM)
-{
- if (GetDocument()->ShowPointerValues()) {
- // invalidate values in the display
- CPoint pt(m_x, m_y); // will be erased
- InvalidateValues();
- FindFmtStrings();
- Update(pt.x, pt.y);
- }
- return 0;
-}
-
void CValuesView::OnUpdate(CView* pSender, LPARAM lHint, ...
{
switch (lHint) {
++<<<<<<< HEAD:SomUI/ValuesWnd.cpp
++=======
+ case UPDATE_MONITORFRAME:
+ {
(hunk truncated for exposition)
Notice that there are no context lines at the beginning of the second
hunk. I would not have expected this, and I think it's a bug in git diff.
I don't feel like diving into the diff machinery, and would appreciate if
someone could have a closer look. I have prepared a small repository to
reproduce the behavior, but I don't want to post it to the public.
-- Hannes
next reply other threads:[~2008-06-12 11:49 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-06-12 11:48 Johannes Sixt [this message]
2008-06-16 11:48 ` git diff --cc bug Johannes Sixt
2008-06-19 6:54 ` Junio C Hamano
2008-06-19 8:11 ` Johannes Sixt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=48510CFA.3060101@viscovery.net \
--to=j.sixt@viscovery.net \
--cc=git@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.