From: Avi Kivity <avi@qumranet.com>
To: Anthony Liguori <anthony@codemonkey.ws>
Cc: Jan Kiszka <jan.kiszka@web.de>, kvm-devel <kvm@vger.kernel.org>,
Hollis Blanchard <hollisb@us.ibm.com>,
Jerone Young <jyoung5@us.ibm.com>,
Joerg Roedel <joerg.roedel@amd.com>
Subject: Re: [PATCH 2/11] QEMU/KVM: Cleanup and improve kvm_load/save_registers usage
Date: Thu, 12 Jun 2008 15:38:11 +0300 [thread overview]
Message-ID: <485118B3.4090509@qumranet.com> (raw)
In-Reply-To: <484D817A.7040204@codemonkey.ws>
Anthony Liguori wrote:
> Jan Kiszka wrote:
>> Remove redundant checkes for kvm_enabled() on register updates between
>> userspace and kvm kernel driver. Ensure register update across all CPUs
>> on "info cpus" monitor command.
>>
>
> This breaks the build when KVM is disabled. The explicit guard is
> needed to avoid having #ifdefs. Please revert.
>
You mean a link time error? Well in that case we're relying on gcc
optimizing away the call. It will break with -O0.
The correct fix is to define stubs for the case kvm is configured out
(or just use ifdefs). But perhaps Glauber's accelerator framework will
take care of all this in a generic fashion.
--
I have a truly marvellous patch that fixes the bug which this
signature is too narrow to contain.
next prev parent reply other threads:[~2008-06-12 12:40 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-05-26 22:05 [PATCH 0/11] Rework guest debug interface / x86 debug register support -v2 Jan Kiszka
2008-05-26 22:09 ` [PATCH 1/11] QEMU/KVM: Fix deadlocks in monitor and debugger Jan Kiszka
2008-05-27 9:36 ` Avi Kivity
2008-05-27 13:00 ` Jan Kiszka
2008-05-27 13:09 ` Avi Kivity
2008-05-26 22:09 ` [PATCH 2/11] QEMU/KVM: Cleanup and improve kvm_load/save_registers usage Jan Kiszka
2008-06-09 19:16 ` Anthony Liguori
2008-06-12 12:38 ` Avi Kivity [this message]
2008-05-26 22:09 ` [PATCH 3/11] QEMU/KVM: Proper vm_stop on debug events Jan Kiszka
2008-05-26 22:09 ` [PATCH 4/11] QEMU: Enhance cpu_break/watchpoint API and gdbstub integration Jan Kiszka
2008-05-26 22:10 ` [PATCH 5/11] QEMU: Improve SMP debugging support Jan Kiszka
2008-05-26 22:10 ` [PATCH 6/11] QEMU/KVM: Introduce single vcpu pause/resume Jan Kiszka
2008-05-26 22:10 ` [PATCH 7/11] QEMU/KVM: New guest debugging interface Jan Kiszka
2008-05-27 18:31 ` Jan Kiszka
2008-05-26 22:10 ` [PATCH 8/11] QEMU/KVM: Support for SMP guest debugging Jan Kiszka
2008-05-26 22:10 ` [PATCH 9/11] KVM: New guest debugging interface Jan Kiszka
2008-05-26 22:10 ` [PATCH 10/11] KVM-x86: Properly virtualize debug registers Jan Kiszka
2008-05-26 22:10 ` [PATCH 11/11] KVM-x86: Wire up host-managed " Jan Kiszka
2008-05-27 9:50 ` [PATCH 0/11] Rework guest debug interface / x86 debug register support -v2 Avi Kivity
2008-05-27 10:44 ` Jan Kiszka
2008-05-27 18:46 ` Hollis Blanchard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=485118B3.4090509@qumranet.com \
--to=avi@qumranet.com \
--cc=anthony@codemonkey.ws \
--cc=hollisb@us.ibm.com \
--cc=jan.kiszka@web.de \
--cc=joerg.roedel@amd.com \
--cc=jyoung5@us.ibm.com \
--cc=kvm@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.