From mboxrd@z Thu Jan 1 00:00:00 1970 Message-ID: <4851271B.8080304@trash.net> Date: Thu, 12 Jun 2008 15:39:39 +0200 From: Patrick McHardy MIME-Version: 1.0 References: <20080611085859.721e3917@extreme> <4850FA96.1050205@trash.net> In-Reply-To: Content-Type: text/plain; charset=ISO-8859-15; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Bridge] Bridge MAC selection List-Id: Linux Ethernet Bridging List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Andy Gospodarek Cc: bridge@lists.linux-foundation.org Andy Gospodarek wrote: > On Thu, Jun 12, 2008 at 7:10 AM, Dietmar Maurer wrote: >>>>> There any side effects with the following patch? >>>> Not for you. But if it got changed now, it would surprise the >>>> existing users (change in ABI behaviour). >> If there are no other side effects, I wonder whats better: >> >> A.) unexpected Network failures due to mac changes >> >> B.) surprised users (does anybody depend on such behavour?) >> >> I vote for A.) >> >> - Dietmar >> > > You might think A is a better option, but option B is frowned upon. I > understand you desire your change the behavior to meet your needs, but > Patrick's suggestion to add a module parameter to tweak this behavior > based on a module option is probably better than simply changing the > existing functionality to meet your needs. I actually meant a brctl parameter, module parameters suck as configuration interfaces. But I think the second option is better, just disable this behaviour automatically when the address is configured manually.