From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1K6ril-0001qk-IN
	for qemu-devel@nongnu.org; Thu, 12 Jun 2008 14:40:27 -0400
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1K6rik-0001px-Oy
	for qemu-devel@nongnu.org; Thu, 12 Jun 2008 14:40:26 -0400
Received: from [199.232.76.173] (port=37848 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1K6rik-0001pi-HX
	for qemu-devel@nongnu.org; Thu, 12 Jun 2008 14:40:26 -0400
Received: from yx-out-1718.google.com ([74.125.44.155]:49403)
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <anthony@codemonkey.ws>) id 1K6rij-00050L-AM
	for qemu-devel@nongnu.org; Thu, 12 Jun 2008 14:40:25 -0400
Received: by yx-out-1718.google.com with SMTP id 3so432192yxi.82
	for <qemu-devel@nongnu.org>; Thu, 12 Jun 2008 11:40:24 -0700 (PDT)
Message-ID: <48516D87.4030407@codemonkey.ws>
Date: Thu, 12 Jun 2008 13:40:07 -0500
From: Anthony Liguori <anthony@codemonkey.ws>
MIME-Version: 1.0
Subject: Re: [Qemu-devel]  [PATCH] Do not redefine DEFAULT_NETWORK_{,
	DOWN_}SCRIPT
References: <18513.23522.456324.983289@mariner.uk.xensource.com>
In-Reply-To: <18513.23522.456324.983289@mariner.uk.xensource.com>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Reply-To: qemu-devel@nongnu.org
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: qemu-devel@nongnu.org

Ian Jackson wrote:
> With this change it is possible to change the default network script
> with a change to CPPFLAGS or a suitable config.h, for example
>   -DDEFAULT_NETWORK_SCRIPT='"/path/to/some/script/of/mine/ifup"' \
>   -DDEFAULT_NETWORK_DOWN_SCRIPT='"/path/to/some/script/of/mine/ifdown"'
>   

This is a good idea, but I think it should be something that is 
specified in ./configure.

Regards,

Anthony Liguori

> My patch assumes that you'll want to override both defaults, or
> neither.
>
> Signed-off-by: Ian Jackson <ian.jackson@eu.citrix.com>
>
> ---
>  vl.c |    2 ++
>  1 files changed, 2 insertions(+), 0 deletions(-)
>
> diff --git a/vl.c b/vl.c
> index f1d92c1..229b536 100644
> --- a/vl.c
> +++ b/vl.c
> @@ -131,8 +131,10 @@ int inet_aton(const char *cp, struct in_addr *ia);
>  
>  #include "exec-all.h"
>  
> +#ifndef DEFAULT_NETWORK_SCRIPT
>  #define DEFAULT_NETWORK_SCRIPT "/etc/qemu-ifup"
>  #define DEFAULT_NETWORK_DOWN_SCRIPT "/etc/qemu-ifdown"
> +#endif
>  #ifdef __sun__
>  #define SMBD_COMMAND "/usr/sfw/sbin/smbd"
>  #else
>