From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1K6uui-0003Hu-4a
	for qemu-devel@nongnu.org; Thu, 12 Jun 2008 18:05:00 -0400
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1K6uug-0003HX-MM
	for qemu-devel@nongnu.org; Thu, 12 Jun 2008 18:04:59 -0400
Received: from [199.232.76.173] (port=32970 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1K6uug-0003HR-Hk
	for qemu-devel@nongnu.org; Thu, 12 Jun 2008 18:04:58 -0400
Received: from il.qumranet.com ([212.179.150.194]:35290)
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <avi@qumranet.com>) id 1K6uug-0008EG-4U
	for qemu-devel@nongnu.org; Thu, 12 Jun 2008 18:04:58 -0400
Message-ID: <48519D83.6070102@qumranet.com>
Date: Fri, 13 Jun 2008 01:04:51 +0300
From: Avi Kivity <avi@qumranet.com>
MIME-Version: 1.0
Subject: Re: [Qemu-devel] [PATCH] New scriptarg=... -net parameter allows
	passing of an argument
References: <18513.23567.23400.891876@mariner.uk.xensource.com>	<48516D47.6080005@codemonkey.ws>	<4851948E.4070300@qumranet.com>
	<48519A19.8080803@codemonkey.ws>
In-Reply-To: <48519A19.8080803@codemonkey.ws>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Reply-To: qemu-devel@nongnu.org
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: qemu-devel@nongnu.org

Anthony Liguori wrote:
>>
>> Environment variables are global, whereas scriptarg is 
>> per-interface.  Consider the case where scriptarg denotes the bridge 
>> name we want the interface to attach to.
>
> Right, what I'm suggesting is that scriptarg=... use an environmental 
> variable (for instance, named SCRIPTARG) when executing the actual 
> script instead of passing it as the second parameter.
>
> It's nicer IMHO because it extends well to passing more data to the 
> script (like whatever the -name parameter is).

Ah, okay.  I don't much like environment variables but I do see the 
advantages here.

-- 
I have a truly marvellous patch that fixes the bug which this
signature is too narrow to contain.