From: Avi Kivity <avi@qumranet.com>
To: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH] Merge NBD client/server int qemu-nbd
Date: Fri, 13 Jun 2008 21:09:17 +0300 [thread overview]
Message-ID: <4852B7CD.3060404@qumranet.com> (raw)
In-Reply-To: <4852B339.5090307@codemonkey.ws>
Anthony Liguori wrote:
>>
>> # qemu-nbd --disconnect /dev/nbd0
>>
>> Regards,
>> Laurent
>> +static void show_parts(const char *device)
>> +{
>> + if (fork() == 0) {
>> + int nbd;
>> +
>> + /* wait device */
>> + sleep(1);
>>
>
> This looks like a big red-herring. What is this sleep waiting for any
> can it be possibly made into something less racy?
It's called udevsettle, if the host is running udev.
--
I have a truly marvellous patch that fixes the bug which this
signature is too narrow to contain.
next prev parent reply other threads:[~2008-06-13 18:09 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-06-13 15:15 [Qemu-devel] [PATCH] Merge NBD client/server int qemu-nbd Laurent Vivier
2008-06-13 17:49 ` Anthony Liguori
2008-06-13 18:09 ` Avi Kivity [this message]
2008-06-13 18:39 ` Laurent Vivier
2008-06-14 15:12 ` Anthony Liguori
2008-06-14 18:47 ` Laurent Vivier
2008-06-14 17:18 ` Avi Kivity
2008-06-14 19:03 ` Laurent Vivier
2008-06-14 19:06 ` Avi Kivity
2008-06-14 19:21 ` Laurent Vivier
2008-06-14 19:35 ` Avi Kivity
2008-06-14 19:54 ` Laurent Vivier
2008-06-15 14:25 ` Anthony Liguori
2008-06-15 15:56 ` Laurent Vivier
2008-06-15 16:00 ` Avi Kivity
2008-06-15 17:39 ` Laurent Vivier
2008-06-19 8:58 ` [Qemu-devel] [PATCH][v2] " Laurent Vivier
2008-06-19 9:18 ` Laurent Vivier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4852B7CD.3060404@qumranet.com \
--to=avi@qumranet.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.