From: Patrick McHardy <kaber@trash.net>
To: Ben Hutchings <bhutchings@solarflare.com>
Cc: David Miller <davem@davemloft.net>,
netdev@vger.kernel.org, linux-net-drivers@solarflare.com
Subject: Re: [PATCH] net: Fix test for VLAN TX checksum offload capability
Date: Sat, 14 Jun 2008 10:08:52 +0200 [thread overview]
Message-ID: <48537C94.70009@trash.net> (raw)
In-Reply-To: <20080613223815.GD11300@solarflare.com>
Ben Hutchings wrote:
> Selected device feature bits can be propagated to VLAN devices, so we
> can make use of TX checksum offload and TSO on VLAN-tagged packets.
> However, if the physical device does not do VLAN tag insertion or
> generic checksum offload then the test for TX checksum offload in
> dev_queue_xmit() will see a protocol of htons(ETH_P_8021Q) and yield
> false.
>
> This splits the checksum offload test into two functions:
>
> - can_checksum_protocol() tests a given protocol against a feature bitmask
>
> - dev_can_checksum() first tests the skb protocol against the device
> features; if that fails and the protocol is htons(ETH_P_8021Q) then
> it tests the encapsulated protocol against the effective device
> features for VLANs
>
> Signed-off-by: Ben Hutchings <bhutchings@solarflare.com>
Acked-by: Patrick McHardy <kaber@trash.net>
next prev parent reply other threads:[~2008-06-14 8:08 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-06-13 22:38 [PATCH] net: Fix test for VLAN TX checksum offload capability Ben Hutchings
2008-06-13 22:43 ` Stephen Hemminger
2008-06-13 23:11 ` Ben Hutchings
2008-06-14 8:09 ` Patrick McHardy
2008-06-14 8:08 ` Patrick McHardy [this message]
2008-06-17 0:02 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=48537C94.70009@trash.net \
--to=kaber@trash.net \
--cc=bhutchings@solarflare.com \
--cc=davem@davemloft.net \
--cc=linux-net-drivers@solarflare.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.