From mboxrd@z Thu Jan 1 00:00:00 1970 From: Heiko Stuebner Subject: Re: [PATCH] drm/rockchip: Convert drm_atomic_helper_suspend/resume() Date: Wed, 01 Aug 2018 15:32:50 +0200 Message-ID: <4854810.RcpRblXvbi@phil> References: <20180731203430.GA30136@jordon-HP-15-Notebook-PC> <1843623.lUM99VBV1x@phil> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Souptick Joarder Cc: Ajit Linux , airlied@linux.ie, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, linux-rockchip@lists.infradead.org, linux-arm-kernel@lists.infradead.org List-Id: linux-rockchip.vger.kernel.org QW0gTWl0dHdvY2gsIDEuIEF1Z3VzdCAyMDE4LCAxNToxNDoyNCBDRVNUIHNjaHJpZWIgU291cHRp Y2sgSm9hcmRlcjoKPiBPbiBXZWQsIEF1ZyAxLCAyMDE4IGF0IDY6NDAgUE0sIEhlaWtvIFN0dWVi bmVyIDxoZWlrb0BzbnRlY2guZGU+IHdyb3RlOgo+ID4gQW0gTWl0dHdvY2gsIDEuIEF1Z3VzdCAy MDE4LCAxNDo0Mzo0NyBDRVNUIHNjaHJpZWIgU291cHRpY2sgSm9hcmRlcjoKPiA+PiBPbiBXZWQs IEF1ZyAxLCAyMDE4IGF0IDY6MDMgUE0sIEhlaWtvIFN0dWVibmVyIDxoZWlrb0BzbnRlY2guZGU+ IHdyb3RlOgo+ID4+ID4gSGkgU291cHRpY2ssCj4gPj4gPgo+ID4+ID4gQW0gRGllbnN0YWcsIDMx LiBKdWxpIDIwMTgsIDIyOjM0OjMwIENFU1Qgc2NocmllYiBTb3VwdGljayBKb2FyZGVyOgo+ID4+ ID4+IGNvbnZlcnQgZHJtX2F0b21pY19oZWxwZXJfc3VzcGVuZC9yZXN1bWUoKSB0byB1c2UKPiA+ PiA+PiBkcm1fbW9kZV9jb25maWdfaGVscGVyX3N1c3BlbmQvcmVzdW1lKCkuCj4gPj4gPj4KPiA+ PiA+PiBXaXRoIHRoaXMgY29udmVyc2lvbiwgcm9ja2NoaXBfZHJtX2ZiX3Jlc3VtZSgpIGFuZAo+ ID4+ID4+IHJvY2tjaGlwX2RybV9mYl9zdXNwZW5kKCkgd2lsbCBub3QgYmUgdXNlZCBhbnltb3Jl Lgo+ID4+ID4+IEJvdGggb2YgdGhlc2UgZnVuY3Rpb25zIGNhbiBiZSByZW1vdmVkLgo+ID4+ID4+ Cj4gPj4gPj4gQWxzbywgaW4gc3RydWN0IHJvY2tjaGlwX2RybV9wcml2YXRlIHN0YXRlIHdpbGwg bm90IGJlCj4gPj4gPj4gdXNlZCBhbnltb3JlLiBTbyB0aGlzIGNhbiBiZSByZW1vdmVkIGZvcmV2 ZXIuCj4gPj4gPj4KPiA+PiA+PiBTaWduZWQtb2ZmLWJ5OiBTb3VwdGljayBKb2FyZGVyIDxqcmRy LmxpbnV4QGdtYWlsLmNvbT4KPiA+PiA+PiBTaWduZWQtb2ZmLWJ5OiBBaml0IE5lZ2kgPGFqaXRu LmxpbnV4QGdtYWlsLmNvbT4KPiA+PiA+Cj4gPj4gPiB0aGUgcGF0Y2ggaXRzZWxmIGxvb2tzIGdy ZWF0LCBqdXN0IGEgc2ltcGxlIGJvb2trZWVwaW5nIHF1ZXN0aW9uLgo+ID4+ID4KPiA+PiA+IFdo YXQgcm9sZSBkaWQgQWppdCBwbGF5IGluIGNyZWF0aW5nIHRoZSBwYXRjaD8gSWYgSSByZW1lbWJl ciBjb3JyZWN0bHkKPiA+PiA+IGl0IGlzIG1lYW50IHRvIGJlCj4gPj4gPiAtIDFzdCBTaWduZWQt b2ZmOiBQYXRjaC1BdXRob3IKPiA+PiA+IC0gMm5kIFNpZ25lZC1vZmY6IEUtTWFpbCBzZW5kZXIg KyBwYXRjaCBwb3NzaWJseSBwYXRjaCBjaGFuZ2VzCj4gPj4gPiAob3B0aW9uYWwgb2YgY291cnNl IGlmIHRoZSBzYW1lKQo+ID4+ID4KPiA+PiA+IFNvIHdhcyB0aGlzIG1lYW50IHRvIGJlIGEgUmV2 aWV3ZWQtYnkgZnJvbSBBaml0Pwo+ID4+Cj4gPj4gV2UgYm90aCBhcmUgd29ya2luZyB0b2dldGhl ciBmb3IgdGhlc2UgcGF0Y2hlcyB0bwo+ID4+IGNvbnZlcnQgZHJtX2F0b21pY19oZWxwZXJfc3Vz cGVuZC9yZXN1bWUoKS4KPiA+PiBUaGF0J3MgdGhlIHJlYXNvbiB0byBhZGQgaGlzIG5hbWUgaW4g Mm5kIFNpZ25lZC1vZmYKPiA+PiBpbiBhbGwgc2ltaWxhciBwYXRjaGVzLgo+ID4+Cj4gPj4gSXMg aXQgYSBpbmNvcnJlY3Qgd2F5IHRvIHB1dCAybmQgU2lnbmVkLW9mZiBoZXJlID8KPiA+Cj4gPiBU aGFua3MgZm9yIHRoZSBjbGFyaWZpY2F0aW9uIGFuZCB0aGUgaW50ZXJlc3RpbmcgcXVlc3Rpb24g Oi0pCj4gPgo+ID4gSSd2ZSBqdXN0IHJlYWQgdGhyb3VnaCBEb2N1bWVudGF0aW9uL3Byb2Nlc3Mv c3VibWl0dGluZy1wYXRjaGVzLnJzdAo+ID4gYW5kIGl0IHNlZW1zIHRoZXJlIGlzIGFuICJvZmZp Y2lhbCIgd2F5IHRvIHNob3cgdGhhdCByZWxhdGlvbnNoaXAsIHZpYSBhCj4gPiB0YWcgbmFtZWQg IkNvLURldmVsb3BlZC1ieToiIGRlc2NyaWJlZCB1bmRlciBudW1iZXIgMTIuCj4gPgo+ID4gU28g SSBndWVzcyB3ZSBjb3VsZCBqdXN0IGFkYXB0IHRoZSBwYXRjaCBhY2NvcmRpbmdseSwgaWYgdGhh dCBpcyBvayB3aXRoCj4gPiBib3RoIG9mIHlvdSAoaS5lLiBJIGNhbiBjaGFuZ2UgdGhpcyB3aGVu IGFwcGx5aW5nLCBzbyBubyBuZWVkIHRvIHJlc2VuZCkuCj4gCj4gV2UgYXJlIG9rIHdpdGggaXQg Oi0pCgphcHBsaWVkIHRvIGRybS1taXNjLW5leHQgd2l0aCB0aGUgc2Vjb25kIHNpZ25lZC1vZmYg Y2hhbmdlZCB0bwpjby1kZXZlbG9wZWQtYnkuCgpUaGFua3MgZm9yIHRoYXQgbmljZSBjbGVhbnVw LgpIZWlrbwoKCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f CmRyaS1kZXZlbCBtYWlsaW5nIGxpc3QKZHJpLWRldmVsQGxpc3RzLmZyZWVkZXNrdG9wLm9yZwpo dHRwczovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2RyaS1kZXZlbAo= From mboxrd@z Thu Jan 1 00:00:00 1970 From: heiko@sntech.de (Heiko Stuebner) Date: Wed, 01 Aug 2018 15:32:50 +0200 Subject: [PATCH] drm/rockchip: Convert drm_atomic_helper_suspend/resume() In-Reply-To: References: <20180731203430.GA30136@jordon-HP-15-Notebook-PC> <1843623.lUM99VBV1x@phil> Message-ID: <4854810.RcpRblXvbi@phil> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org Am Mittwoch, 1. August 2018, 15:14:24 CEST schrieb Souptick Joarder: > On Wed, Aug 1, 2018 at 6:40 PM, Heiko Stuebner wrote: > > Am Mittwoch, 1. August 2018, 14:43:47 CEST schrieb Souptick Joarder: > >> On Wed, Aug 1, 2018 at 6:03 PM, Heiko Stuebner wrote: > >> > Hi Souptick, > >> > > >> > Am Dienstag, 31. Juli 2018, 22:34:30 CEST schrieb Souptick Joarder: > >> >> convert drm_atomic_helper_suspend/resume() to use > >> >> drm_mode_config_helper_suspend/resume(). > >> >> > >> >> With this conversion, rockchip_drm_fb_resume() and > >> >> rockchip_drm_fb_suspend() will not be used anymore. > >> >> Both of these functions can be removed. > >> >> > >> >> Also, in struct rockchip_drm_private state will not be > >> >> used anymore. So this can be removed forever. > >> >> > >> >> Signed-off-by: Souptick Joarder > >> >> Signed-off-by: Ajit Negi > >> > > >> > the patch itself looks great, just a simple bookkeeping question. > >> > > >> > What role did Ajit play in creating the patch? If I remember correctly > >> > it is meant to be > >> > - 1st Signed-off: Patch-Author > >> > - 2nd Signed-off: E-Mail sender + patch possibly patch changes > >> > (optional of course if the same) > >> > > >> > So was this meant to be a Reviewed-by from Ajit? > >> > >> We both are working together for these patches to > >> convert drm_atomic_helper_suspend/resume(). > >> That's the reason to add his name in 2nd Signed-off > >> in all similar patches. > >> > >> Is it a incorrect way to put 2nd Signed-off here ? > > > > Thanks for the clarification and the interesting question :-) > > > > I've just read through Documentation/process/submitting-patches.rst > > and it seems there is an "official" way to show that relationship, via a > > tag named "Co-Developed-by:" described under number 12. > > > > So I guess we could just adapt the patch accordingly, if that is ok with > > both of you (i.e. I can change this when applying, so no need to resend). > > We are ok with it :-) applied to drm-misc-next with the second signed-off changed to co-developed-by. Thanks for that nice cleanup. Heiko From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4B747C28CF6 for ; Wed, 1 Aug 2018 13:32:59 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 083CA208A5 for ; Wed, 1 Aug 2018 13:32:58 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 083CA208A5 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=sntech.de Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2389426AbeHAPSp (ORCPT ); Wed, 1 Aug 2018 11:18:45 -0400 Received: from gloria.sntech.de ([185.11.138.130]:34118 "EHLO gloria.sntech.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2389278AbeHAPSp (ORCPT ); Wed, 1 Aug 2018 11:18:45 -0400 Received: from wd0970.dip.tu-dresden.de ([141.76.111.202] helo=phil.localnet) by gloria.sntech.de with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1fkrFD-0005Ll-Pc; Wed, 01 Aug 2018 15:32:51 +0200 From: Heiko Stuebner To: Souptick Joarder Cc: hjc@rock-chips.com, airlied@linux.ie, Ajit Linux , Daniel Vetter , dri-devel@lists.freedesktop.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] drm/rockchip: Convert drm_atomic_helper_suspend/resume() Date: Wed, 01 Aug 2018 15:32:50 +0200 Message-ID: <4854810.RcpRblXvbi@phil> In-Reply-To: References: <20180731203430.GA30136@jordon-HP-15-Notebook-PC> <1843623.lUM99VBV1x@phil> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Am Mittwoch, 1. August 2018, 15:14:24 CEST schrieb Souptick Joarder: > On Wed, Aug 1, 2018 at 6:40 PM, Heiko Stuebner wrote: > > Am Mittwoch, 1. August 2018, 14:43:47 CEST schrieb Souptick Joarder: > >> On Wed, Aug 1, 2018 at 6:03 PM, Heiko Stuebner wrote: > >> > Hi Souptick, > >> > > >> > Am Dienstag, 31. Juli 2018, 22:34:30 CEST schrieb Souptick Joarder: > >> >> convert drm_atomic_helper_suspend/resume() to use > >> >> drm_mode_config_helper_suspend/resume(). > >> >> > >> >> With this conversion, rockchip_drm_fb_resume() and > >> >> rockchip_drm_fb_suspend() will not be used anymore. > >> >> Both of these functions can be removed. > >> >> > >> >> Also, in struct rockchip_drm_private state will not be > >> >> used anymore. So this can be removed forever. > >> >> > >> >> Signed-off-by: Souptick Joarder > >> >> Signed-off-by: Ajit Negi > >> > > >> > the patch itself looks great, just a simple bookkeeping question. > >> > > >> > What role did Ajit play in creating the patch? If I remember correctly > >> > it is meant to be > >> > - 1st Signed-off: Patch-Author > >> > - 2nd Signed-off: E-Mail sender + patch possibly patch changes > >> > (optional of course if the same) > >> > > >> > So was this meant to be a Reviewed-by from Ajit? > >> > >> We both are working together for these patches to > >> convert drm_atomic_helper_suspend/resume(). > >> That's the reason to add his name in 2nd Signed-off > >> in all similar patches. > >> > >> Is it a incorrect way to put 2nd Signed-off here ? > > > > Thanks for the clarification and the interesting question :-) > > > > I've just read through Documentation/process/submitting-patches.rst > > and it seems there is an "official" way to show that relationship, via a > > tag named "Co-Developed-by:" described under number 12. > > > > So I guess we could just adapt the patch accordingly, if that is ok with > > both of you (i.e. I can change this when applying, so no need to resend). > > We are ok with it :-) applied to drm-misc-next with the second signed-off changed to co-developed-by. Thanks for that nice cleanup. Heiko